Skip to content

[CI] Stop requiring both API servers to record weight sync metrics #59521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aoshen02 merged 2 commits into from
Oct 4, 2026
Merged

[CI] Stop requiring both API servers to record weight sync metrics #59521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc68c25
[CI][Test] Stop requiring both API servers to record weight sync metrics
aarushjain29 Oct 1, 2026
ce0db0a
Merge branch 'main' into rocm/fix-weight-sync-metrics-flake
AndreasKaratzas Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 3 additions & 26 deletions tests/entrypoints/serve/dev/rlhf/test_weight_operation_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,8 @@
# SPDX-FileCopyrightText: Copyright contributors to the vLLM project
"""Weight-transfer metrics scraped from a real two-API-server deployment."""

from pathlib import Path

import requests
import torch
from prometheus_client.multiprocess import MultiProcessCollector
from prometheus_client.parser import text_string_to_metric_families
from transformers import AutoModelForCausalLM

Expand All @@ -21,10 +18,7 @@

DURATION = "vllm:rl_weight_update_operation_duration_seconds"
IN_FLIGHT = "vllm:rl_weight_update_operations_in_flight"
# The API servers accept from one shared listening socket, so the kernel may
# hand one process most connections. Sync until both have recorded, within a cap.
MIN_SYNCS = 8
MAX_SYNCS = 64
SYNCS = 8


def scrape(url: str) -> dict[tuple[str, str], float]:
Expand All @@ -37,17 +31,6 @@ def scrape(url: str) -> dict[tuple[str, str], float]:
}


def pids_that_recorded(multiproc_dir: Path) -> set[str]:
return {
path.stem.rsplit("_", 1)[1]
for path in multiproc_dir.glob("histogram_*.db")
if any(
metric.name == DURATION
for metric in MultiProcessCollector.merge([str(path)])
)
}


def test_weight_sync_metrics_aggregate_across_api_servers(tmp_path):
args = [
"--load-format",
Expand Down Expand Up @@ -77,17 +60,11 @@ def test_weight_sync_metrics_aggregate_across_api_servers(tmp_path):
client=HTTPVLLMWeightSyncClient(url),
source=ModuleSource(trainer),
)
syncs = 0
while syncs < MIN_SYNCS or (
len(pids_that_recorded(tmp_path)) < 2 and syncs < MAX_SYNCS
):
for _ in range(SYNCS):
engine.send_weights()
syncs += 1
metrics = scrape(url)

calls = {"init": 1, "start": syncs, "update": syncs, "finish": syncs}
calls = {"init": 1, "start": SYNCS, "update": SYNCS, "finish": SYNCS}
for operation, count in calls.items():
assert metrics[(f"{DURATION}_count", operation)] == count, operation
assert metrics[(IN_FLIGHT, operation)] == 0, operation
# The counts above are sums over processes only if both servers recorded.
assert len(pids_that_recorded(tmp_path)) == 2
Loading