Repository navigation
[CI] Fix MiniMax-M3 PP aux-state test mock after #58648 - #59508
Merged
njhill merged 1 commit intoOct 1, 2026
Merged
Conversation
vllm-project#58648 made MiniMaxM3Model read vllm_config.use_v2_model_runner and speculative_config. The test's SimpleNamespace config lacked both, so test_eagle3_aux_hidden_states_pp.py fails with AttributeError on main. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: venkywonka <23023424+venkywonka@users.noreply.github.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
4 of 6 tasks
2 of 7 tasks
This was referenced Sep 30, 2026
njhill
approved these changes
Sep 30, 2026
Member
|
/ci run |
|
✅ @venkywonka, CI is now available for this PR.
|
|
✅ Triggered Buildkite CI #92277 for commit |
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
tests/v1/worker/test_eagle3_aux_hidden_states_pp.pyfails on main with 5×AttributeError: 'types.SimpleNamespace' object has no attribute 'use_v2_model_runner'(seen in thev1-executor-plus-workerstep on NVIDIA and AMD).#58648 made
MiniMaxM3Model.__init__readvllm_config.use_v2_model_runnerandvllm_config.speculative_config. #57197 added this test with aSimpleNamespaceconfig that has neither, and it merged on CI results from before #58648. Each PR passed on its own; together they break.This adds
speculative_config=Noneanduse_v2_model_runner=Falseto the test's mock config. With no speculative config,spec_decode_needs_target_embedreturns False, so the test exercises the same behavior as before #58648. Test-only change, +4/−1.Not a duplicate: no open PR or issue references this test or failure.
Test Plan
Test Result
On an RTX PRO 6000 (SM120):
use_v2_model_runnerAttributeError)AI assistance (Claude Code) was used to find the cause, write the fix and run the tests.
🤖 Generated with Claude Code