Skip to content

[Tests][Multimodal] Cover scoped processor kwargs precedence #59399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DarkLight1337 merged 2 commits into from
Sep 30, 2026
Merged

[Tests][Multimodal] Cover scoped processor kwargs precedence #59399

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d1608f
[Tests][Multimodal] Cover scoped processor kwargs precedence
apex-mochen Sep 30, 2026
cea2f74
Merge branch 'main' into codex/vllm-56372-followup
DarkLight1337 Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions tests/config/test_multimodal_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,43 @@ def test_merge_mm_processor_kwargs_scoped_precedence():
}


def test_merge_mm_processor_kwargs_preserves_scoped_siblings_and_precedence():
config = MultiModalConfig(
mm_processor_kwargs={
"size": {
"shortest_edge": 100,
"longest_edge": 1000,
},
"videos_kwargs": {
"fps": 2,
"size": {"longest_edge": 1200},
},
},
mm_device_do_normalize=False,
)

assert config.merge_mm_processor_kwargs(
{
"size": {"longest_edge": 1800},
"videos_kwargs": {
"size": {"shortest_edge": 200},
},
}
) == {
"size": {
"shortest_edge": 100,
"longest_edge": 1800,
},
"videos_kwargs": {
"fps": 2,
"size": {
"shortest_edge": 200,
"longest_edge": 1800,
},
},
}


def test_merge_mm_processor_kwargs_mapping_vs_replacement():
config = MultiModalConfig(
mm_processor_kwargs={
Expand Down
Loading