Repository navigation
[Feature][Rust Frontend] Add Shutdown control RPC - #59316
Merged
BugenZhao merged 5 commits intoSep 30, 2026
Merged
Conversation
Co-authored-by: Codex Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Co-authored-by: Codex Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
JulienDarve
requested review from
BugenZhao,
jperezdealgaba and
njhill
as code owners
September 29, 2026 23:29
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Documentation preview: https://vllm--59316.org.readthedocs.build/en/59316/ |
Member
|
[AUTOMATED] @codex review |
Co-authored-by: Codex Signed-off-by: Julien Darve <jdarve@NVIDIA.com>
Replace the `serve_with_engine_shutdown` entry point and duplicated `Option<CancellationToken>` with a `Config.manages_engine` flag, set only by managed `vllm-rs serve` with local engines. Drop the misplaced online-serving docs section and note the FAILED_PRECONDITION contract in control.proto. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
approved these changes
Sep 30, 2026
Member
There was a problem hiding this comment.
Thanks @JulienDarve the interface looks reasonable. Added a commit to simplify things a bit
Member
|
/ci run |
|
✅ @JulienDarve, CI is now available for this PR.
|
BugenZhao
enabled auto-merge (squash)
September 30, 2026 12:04
|
✅ Triggered Buildkite CI #92128 for commit |
14 of 49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add
Control.Shutdownso a trusted sidecar can request a fresh managed engine when required cache-event replay history is unavailable.Managed
vllm-rs servereuses its configured SIGTERM shutdown path. Frontend-only modes returnFAILED_PRECONDITION. The response acknowledges acceptance; shutdown may close the connection before it arrives.Bump
vllm-prototo 0.5.0 because the generated Control trait gains a required method.Upstream searches found no open PR adding a Shutdown or KillEngine gRPC method. Related #56886 covers discovery withdrawal grace and does not add a shutdown RPC.
AI assistance was used through OpenAI Codex.
Test Plan
cargo nextest run --manifest-path rust/Cargo.toml -p vllm-server -p vllm-cmd -E 'test(grpc::tests::) | binary(vllm-rs)'cargo publish --manifest-path rust/proto/Cargo.toml --locked --dry-run --allow-dirtyTest Result