Repository navigation
[Bugfix] Revert "[ROCm][Perf] Replace torch.topk in DSA candidate block selection" - #59125
Merged
ywang96 merged 1 commit intoSep 29, 2026
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Collaborator
Author
|
/ci run |
|
✅ @Fangzhou-Ai, CI is now available for this PR.
|
|
✅ Triggered Buildkite CI #91727 for commit |
…ion (vllm-project#58208)" This reverts commit 6b24bd8. Signed-off-by: Fangzhou Ai <31551580+Fangzhou-Ai@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Fangzhou-Ai
force-pushed
the
revert-58208-rocm-dsa-candidate-topk
branch
from
September 29, 2026 03:05
0cf8f36 to
3ac8c04
Compare
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #91728 for commit |
Fangzhou-Ai
changed the title
Collaborator
Author
|
/ci run |
|
✅ CI is already running for this commit: https://buildkite.com/vllm/ci/builds/91728 |
ywang96
approved these changes
Sep 29, 2026
This was referenced Sep 29, 2026
chunfangamd
added a commit
to SemiAnalysisAI/InferenceX
that referenced
this pull request
Sep 30, 2026
…m#58208 vllm-project/vllm#58208 was reverted by vllm-project/vllm#59125 before the pinned build, so the image only carries #58655 and #53492. Comment-only change. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am reverting #58208 for 2 reasons: 1, there are some potential bugs under some certain shape, 2 the path will be replaced by #58671 is introducing a new path which is much faster so no need to further improve the kernel here.