Repository navigation
[Bugfix][Core] Remove redundant AuxOutput reset guards after pause - #59060
Merged
aoshen02 merged 6 commits intoSep 29, 2026
Merged
Conversation
…ests Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
aoshen02
requested review from
ApostaC,
WoosukKwon,
alexm-redhat,
heheda12345,
ivanium,
njhill,
orozery,
robertgshaw2-redhat and
ywang96
as code owners
September 28, 2026 15:32
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
Author
|
/ci run |
aoshen02
enabled auto-merge (squash)
September 28, 2026 15:34
|
✅ Triggered Buildkite CI #91612 for commit |
njhill
approved these changes
Sep 28, 2026
Contributor
Author
|
/ci run |
Keep the in-flight output guard and test reset without a keep-mode pause. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
aoshen02
changed the title
Remove the AuxOutput-specific in-flight guard and consume queued outputs at the EngineCoreProc reset boundary without scheduling new batches. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
aoshen02
changed the title
Remove the added EngineCore queue draining and its tests. Keep removal of the AuxOutput-specific reset guards, with callers responsible for awaiting pause completion before reset. Co-authored-by: Codex <noreply@openai.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
aoshen02
changed the title
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #91789 for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AuxOutput reset checks unnecessarily constrain the pause mode. For example, an abort-mode pause can finish draining outputs without setting
PAUSED_ALL.The supported workflow is to await pause completion before explicitly resetting the prefix cache. With
clear_cache=True, pause performs the reset internally after draining. This PR does not add support for resetting AuxOutput during active inference without a completed pause.Change
Scheduler.reset_prefix_cache.core.pyis restored to its pre-change implementation.AuxOutput generation, temporary-state cleanup, and storage retention are unchanged. This does not implement retaining R3 across a GPU-only cache reset.
Validation
/home/aoshen/vllm/.venv/bin/python -m pytest tests/v1/engine/test_engine_core.py tests/v1/core/test_scheduler.py -k 'reset_prefix_cache or aux_output_reset or pause_synchronizes_device_before_cache_reset' -q: 5 passed, 210 deselected.Related work
This updates the existing fix rather than opening a duplicate. #56754 concerns in-process sleep waiting; #57810 concerns retaining external KV connector state. Broader investigation: aoshen02#82.
AI assistance was used. Human review is required before merge.