Skip to content

[CI][Bugfix] Document 404 response for /generative_scoring - #58844

Closed
robertgshaw2-redhat wants to merge 1 commit into
vllm-project:mainfrom
robertgshaw2-redhat:claude/inspiring-ritchie-3dssax
Closed

robertgshaw2-redhat wants to merge 1 commit into
vllm-project:mainfrom
robertgshaw2-redhat:claude/inspiring-ritchie-3dssax

Conversation

@robertgshaw2-redhat

@robertgshaw2-redhat robertgshaw2-redhat commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

The handler returns a 404 ErrorResponse for unknown model names, but the route's OpenAPI responses omitted it, failing schemathesis in tests/entrypoints/openai/test_openai_schema.py.

Claude-Session: https://claude.ai/code/session_01Vt9AmavweJ5Bqq5LjajgcR

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

The handler returns a 404 ErrorResponse for unknown model names, but the
route's OpenAPI responses omitted it, failing schemathesis in
tests/entrypoints/openai/test_openai_schema.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Vt9AmavweJ5Bqq5LjajgcR

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added frontend bug Something isn't working labels Sep 26, 2026
@DarkLight1337
DarkLight1337 enabled auto-merge (squash) September 26, 2026 15:01
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 26, 2026
@DarkLight1337

Copy link
Copy Markdown
Member

/ci run --allow-stale

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #91408 for commit 658d8a41a3f2.

⚠️ This PR is 32 commits behind upstream main. Running CI at your own risk because --allow-stale was requested; outdated CI configuration may cause failures. Before merging, merge or rebase onto the latest main, then rerun /ci run on the latest PR commit.

@markmc

markmc commented Sep 28, 2026

Copy link
Copy Markdown
Member

Fixed by #58788

@markmc markmc closed this Sep 28, 2026
auto-merge was automatically disabled September 28, 2026 12:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants