Skip to content

[ROCm][CI] Mirror generic GEMM-RS/AR on MI355 - #58433

Merged
AndreasKaratzas merged 9 commits into
vllm-project:mainfrom
AndreasKaratzas:akaratza_amd_gemm_rs_ar
Sep 29, 2026
Merged

AndreasKaratzas merged 9 commits into
vllm-project:mainfrom
AndreasKaratzas:akaratza_amd_gemm_rs_ar

Conversation

@AndreasKaratzas

@AndreasKaratzas AndreasKaratzas commented Sep 23, 2026 •

Copy link
Copy Markdown
Member
  • Add a MI355 mirror beneath the current gemm-rs-ar-2xb200 parent and a matching native AMD job, with four GPUs, a 20-minute timeout, and source dependencies covering the tested production paths.
  • Add test_rocm_gemm_rs_ar.py for BF16 and native MXFP8 at TP2 and TP4, exercising production RowParallelLinear, AITER all-reduce, and RCCL reduce-scatter with explicit backend assertions.
  • Cover the expanded parent's shape transitions, fully padded ranks, zero reduce-scatter tails, retained output lifetime, and graph replay with changing rank-distinct inputs against an independent numerical reference.

The generic GEMM-RS/AR parent introduced by #57428 extends the former Kimi-specific coverage with MXFP8 and additional shape and padding checks. The older #50519 proposal uses the removed Kimi helper and needs its test workload updated along with its parent association. This change adds coverage for the expanded contract through supported ROCm execution paths and checks native MXFP8 dispatch explicitly. It establishes correctness coverage; fused GEMM/communication overlap and performance parity remain unmeasured.

AI assistance was used for implementation, review, local validation, and this description.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: Andreas Karatzas <andreas.karatzas@protonmail.com>
@mergify mergify Bot added ci/build rocm Related to AMD ROCm labels Sep 23, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Sep 23, 2026
@AndreasKaratzas
AndreasKaratzas marked this pull request as ready for review September 23, 2026 19:58
@AndreasKaratzas

Copy link
Copy Markdown
Member Author

/ci run

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #90750 for commit 0f10c759c2a2.

@AndreasKaratzas AndreasKaratzas left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreasKaratzas

Copy link
Copy Markdown
Member Author

Setting it to draft mode until ROCm/aiter#5807 is upstreamed.

@AndreasKaratzas
AndreasKaratzas marked this pull request as draft September 24, 2026 03:22
@AndreasKaratzas
AndreasKaratzas marked this pull request as ready for review September 28, 2026 05:25
@AndreasKaratzas

Copy link
Copy Markdown
Member Author

/ci run

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #91536 for commit 6b4e0f68745d.

@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 29, 2026
@tjtanaa

tjtanaa commented Sep 29, 2026

Copy link
Copy Markdown
Member

/ci run

@github-actions

Copy link
Copy Markdown

✅ CI is already running for this commit: https://buildkite.com/vllm/ci/builds/91536

AndreasKaratzas and others added 2 commits September 29, 2026 07:26
Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: Andreas Karatzas <andreas.karatzas@protonmail.com>
@AndreasKaratzas

Copy link
Copy Markdown
Member Author

/ci run

@AndreasKaratzas
AndreasKaratzas enabled auto-merge (squash) September 29, 2026 07:28
@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #91782 for commit d42ca939937f.

AndreasKaratzas and others added 2 commits September 29, 2026 07:41
The AMD pipeline derives block step keys from labels and cannot upload keys containing a period.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: Andreas Karatzas <andreas.karatzas@protonmail.com>
@AndreasKaratzas

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #91790 for commit 2404ad4a22bf.

@AndreasKaratzas

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

❌ This PR is 5 commits behind upstream main. Your branch must contain every commit currently on upstream main. No new CI build was started. Merge or rebase onto the latest main, then rerun /ci run. To test this branch at your own risk, use /ci run --allow-stale.

@AndreasKaratzas

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #91818 for commit 3db9d5b3d318.

@AndreasKaratzas
AndreasKaratzas merged commit 05d8963 into vllm-project:main Sep 29, 2026
68 checks passed
@AndreasKaratzas
AndreasKaratzas deleted the akaratza_amd_gemm_rs_ar branch September 29, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants