Repository navigation
[Model Runner V2] Support randomized dummy inputs #58411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khluu
merged 5 commits into
vllm-project:main
from
robertgshaw2-redhat:claude/fervent-heisenberg-omfvnt
Oct 1, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
da509fd
[Model Runner V2] Support randomized dummy inputs
9ed7d30
Merge branch 'main' into claude/fervent-heisenberg-omfvnt
mergify[bot] d16df5b
Merge branch 'main' into claude/fervent-heisenberg-omfvnt
njhill 53b7cd5
Merge branch 'main' into claude/fervent-heisenberg-omfvnt
robertgshaw2-redhat b72e6e3
Merge branch 'main' into claude/fervent-heisenberg-omfvnt
robertgshaw2-redhat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine to cache this though - it's probably fine to always randomize if we started with DP > 1 since DP=1 would likely only be a transient state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this only for the profile run? I think we may want to randomize for CUDA graph capture even for DP=1 so we don't get weird autotuning/algorithm selection due to expert imbalance. @benchislett brought this up recently
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then would it be better for this to be
envs.VLLM_RANDOMIZE_DP_DUMMY_INPUTS and self.model_config.is_moe?Or should we just have
VLLM_RANDOMIZE_DP_DUMMY_INPUTSdefault to true in MoE case?