Repository navigation
[DeepSeek V4] Fix fused MoE expert distribution #57465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tlrmchlsmth
merged 4 commits into
vllm-project:main
from
itayalroy:fix_dsv4_fused_moe_expert_distribution
Sep 18, 2026
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
020e9b1
[DeepSeek V4] Fix fused MoE expert distribution
itayalroy f22f779
Merge branch 'main' into fix_dsv4_fused_moe_expert_distribution
tlrmchlsmth aa87ac1
Remove redundant expert divisibility check
itayalroy 7ca83ab
Merge branch 'main' into fix_dsv4_fused_moe_expert_distribution
tlrmchlsmth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually too strict - we don't require divisibility for
ep_size... at least not in all casesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked a few other FusedMoE models (including DSV2/V3). They also calculate the number of local physical experts as num_physical_experts // ep_size, they just do not assert divisibility. I aligned DeepSeek V4 with them. Currently this is only read by EPLB, but I wonder if we should make a broader change to account for uneven distribution across all models.