Skip to content

[CI] Relax sharded-sampling divergence bound on ROCm #57369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khluu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[CI] Relax sharded-sampling divergence bound on ROCm #57369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions tests/v1/e2e/general/test_sharded_sampling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,18 @@
from tests.utils import multi_gpu_test
from vllm import LLM, SamplingParams
from vllm.distributed import cleanup_dist_env_and_memory
from vllm.platforms import current_platform

MODEL = "meta-llama/Llama-3.2-1B-Instruct"

# Boot-state numeric noise bound (measured <= 0.25 on identical contexts).
LOGPROB_TOL = 0.5
# Near-tie greedy/seeded flips from boot-state noise; measured <= 1 per
# engine boot across ~16 completions, plus one of headroom.
MAX_DIVERGENT_PROMPTS = 3
# Near-tie greedy/seeded flips from boot-state noise. On CUDA this is measured
# <= 1 per engine boot across ~16 completions. ROCm boots land in noisier
# kernel/collective states (5-7 divergent prompts observed on MI300), so allow
# more headroom there. A real sharding bug diverges on nearly every prompt, far
# above either bound.
MAX_DIVERGENT_PROMPTS = 8 if current_platform.is_rocm() else 3

PROMPTS = [
"The capital of France is",
Expand Down
Loading