Skip to content

[CI] Fix ruff docstring violations in EC connector files - #57283

Merged
khluu merged 1 commit into
mainfrom
fix/ec-connector-ruff-docstring
Sep 17, 2026
Merged

khluu merged 1 commit into
mainfrom
fix/ec-connector-ruff-docstring

Conversation

@khluu

@khluu khluu commented Sep 17, 2026

Copy link
Copy Markdown
Member

What

Fix pre-commit ruff failures on main caused by merge skew between:

The PR (#54960) passed CI before the pydocstyle rules were enabled on main, but was merged without rebasing, causing D200 violations in:

  • vllm/distributed/ec_transfer/ec_connector/base.py
  • vllm/distributed/ec_transfer/ec_connector/metrics.py

Changes

Pure ruff auto-fixes: move opening """ to the same line as the first text (D200) and collapse single-line docstrings to one line (ruff-format).

Testing

  • pre-commit run ruff-check --all-files passes
  • pre-commit run ruff-format --all-files passes

AI Disclosure

This fix was generated with AI assistance (Kimi Code CLI). The changes are purely mechanical ruff auto-fixes with no semantic modifications.

Fix D200 and docstring formatting violations in
vllm/distributed/ec_transfer/ec_connector/base.py and
vllm/distributed/ec_transfer/ec_connector/metrics.py
that broke pre-commit on main after #54960 merged without
rebasing onto the new pydocstyle rules from #52136.

Co-authored-by: Kimi Code <noreply@moonshot.ai>
Signed-off-by: khluu <khluu@users.noreply.github.com>

Signed-off-by: khluu <khluu000@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@Isotr0py
Isotr0py enabled auto-merge (squash) September 17, 2026 04:02
@Isotr0py

Copy link
Copy Markdown
Member

/ci run

@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 17, 2026
@github-actions

Copy link
Copy Markdown

❌ This PR is 1 commit behind upstream main. Your branch must contain every commit currently on upstream main. No new CI build was started. Merge or rebase onto the latest main, then rerun /ci run. To test this branch at your own risk, use /ci run --allow-stale.

@Isotr0py

Copy link
Copy Markdown
Member

/ci run --allow-stale

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #89531 for commit 4686e1b828cc.

⚠️ This PR is 1 commit behind upstream main. Running CI at your own risk because --allow-stale was requested; outdated CI configuration may cause failures. Before merging, merge or rebase onto the latest main, then rerun /ci run on the latest PR commit.

@khluu

khluu commented Sep 17, 2026

Copy link
Copy Markdown
Member Author

/ci cancel

@khluu
khluu disabled auto-merge September 17, 2026 04:13
@khluu
khluu merged commit 0bfc7a1 into main Sep 17, 2026
20 of 28 checks passed
@khluu
khluu deleted the fix/ec-connector-ruff-docstring branch September 17, 2026 04:13
@github-actions

Copy link
Copy Markdown

✅ Requested cancellation of 1 CI build for fix/ec-connector-ruff-docstring: #89531.

@shen-shanshan shen-shanshan mentioned this pull request Sep 17, 2026
3 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants