Repository navigation
[XPU] Dispatch nn.LayerNorm to fused SYCL kernel via CustomOp #57172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hmellor
merged 12 commits into
vllm-project:main
from
mganczarenko:xpu-layernorm-sycl-wiring
Sep 30, 2026
Merged
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2796328
[XPU] Dispatch nn.LayerNorm to fused SYCL kernel via CustomOp
mganczarenko d7fca5a
[XPU] Use contiguous out buffer in layer_norm/nemotron_layer_norm ker…
mganczarenko 0ddf3de
[XPU] Wrap LayerNorm SYCL ops as proper custom ops, drop is_compiling…
mganczarenko 0e20568
[XPU] Exclude OlmoForCausalLM from the generic LayerNorm swap
mganczarenko 67896a6
Merge branch 'main' into xpu-layernorm-sycl-wiring
mganczarenko 59f244e
Merge branch 'main' into xpu-layernorm-sycl-wiring
mganczarenko 5048cbd
Merge branch 'main' into xpu-layernorm-sycl-wiring
mganczarenko ff208db
[XPU] Fold LayerNorm into the layer_norm CustomOp
mganczarenko db1ccb5
Merge branch 'main' into xpu-layernorm-sycl-wiring
mganczarenko f2273da
[XPU] Remove dead OlmoForCausalLM LayerNorm-swap exclusion: OlmoLayer…
mganczarenko 7b1c1d3
Merge branch 'main' into xpu-layernorm-sycl-wiring
mganczarenko e9f2f1c
Merge branch 'main' into xpu-layernorm-sycl-wiring
hmellor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just call it
LayerNorm?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already LayerNorm class being nn.Module at the end of the file, but I am open for alternatives for the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we port the other
LayerNormto be a custom op instead of adding a new one with a different name?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could. Please, take a look and let me know if it looks good to you - ff208db
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CC: @jikunshang, @mayuyuace