-
-
Notifications
You must be signed in to change notification settings - Fork 22.3k
[Bugfix][Kimi K3] Split DSpark draft out of the target MLA KV group #56952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+53
−0
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM project | ||
| """The K3 DSpark draft must not merge into the target's MLA KV cache group.""" | ||
|
|
||
| from types import SimpleNamespace | ||
|
|
||
| import pytest | ||
|
|
||
| from vllm.models.kimi_k3.nvidia.mla import MultiHeadLatentAttention | ||
| from vllm.v1.kv_cache_interface import MLAAttentionSpec | ||
|
|
||
|
|
||
| def _get_spec(non_causal_multi_token_decode: bool) -> MLAAttentionSpec: | ||
| mla = MultiHeadLatentAttention.__new__(MultiHeadLatentAttention) | ||
| mla.kv_cache_dtype = "auto" | ||
| mla.head_size = 576 | ||
| mla.non_causal_multi_token_decode = non_causal_multi_token_decode | ||
| vllm_config = SimpleNamespace( | ||
| cache_config=SimpleNamespace(block_size=64), | ||
| model_config=None, | ||
| ) | ||
| return mla.get_kv_cache_spec(vllm_config) # type: ignore[arg-type] | ||
|
|
||
|
|
||
| def test_dspark_draft_spec_carries_model_version(): | ||
| spec = _get_spec(non_causal_multi_token_decode=True) | ||
| assert spec.model_version == "kimi_k3_dspark" | ||
|
|
||
|
|
||
| def test_target_spec_has_no_model_version(): | ||
| spec = _get_spec(non_causal_multi_token_decode=False) | ||
| assert spec.model_version is None | ||
|
|
||
|
|
||
| def test_dspark_draft_spec_cannot_merge_into_target_group(): | ||
| # The split matters because MLAAttentionSpec.merge ORs | ||
| # non_causal_multi_token_decode, which would flag the causal target. | ||
| with pytest.raises(AssertionError, match="model version"): | ||
| MLAAttentionSpec.merge( | ||
| [ | ||
| _get_spec(non_causal_multi_token_decode=False), | ||
| _get_spec(non_causal_multi_token_decode=True), | ||
| ] | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we may still want to allocate the kv cache as one group, but fix trtion mla behavior.
A quick search in community it feels #51065 is closer to a proper fix. Could you check if this PR fix your use case?