[WIP] [Speculative Decoding] Use MQA kernel for target model verification#5691
Closed
LiuXiaoxuanPKU wants to merge 23 commits intovllm-project:mainfrom
Closed
[WIP] [Speculative Decoding] Use MQA kernel for target model verification#5691LiuXiaoxuanPKU wants to merge 23 commits intovllm-project:mainfrom
LiuXiaoxuanPKU wants to merge 23 commits intovllm-project:mainfrom
Conversation
Collaborator
Author
|
Some preliminary benchmark results of reducing the scoring time.
|
Collaborator
Author
|
This PR is based on #6052, otherwise, it's hard to add the cuda graph support. |
|
The MQAScorer cannot handle the case when |
Collaborator
Author
|
closed as moved to #8839 |
Contributor
|
Hello, I wonder whether MQA in 'MQA kernel' is related to MQA in 'MHA, GQA, MQA'?MQA confuses me a lot. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the first attempt to use MQA kernel for target model verification, therefore we can remove the overhead of batch expansion. Currently it uses flash attention
flash_attn_varlen_funcfor verification. We can use flashinfer as the next step. The tricky part is to add cuda graph support.Some difficulties:
_num_computed_tokens, which is a field used by chunked prefill and this needs more attention here.TODO:
RFC for this PR