[Minor] Invert MRV1 specdec method fallback logic - #56899
Merged
Merged
Conversation
Signed-off-by: Nick Hill <nickhill123@gmail.com>
njhill
requested review from
ProExpertProg,
WoosukKwon,
houseroad,
mgoin,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
September 14, 2026 21:21
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
njhill
changed the title
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #88926 for commit |
WoosukKwon
approved these changes
Sep 15, 2026
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 15, 2026
Signed-off-by: Nick Hill <nickhill123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we are looking at MRV1 deprecation, change the spec decode method check to be based on unsupported methods rather than supported ones; unify with unnecessarily separate ngram check.