Repository navigation
[Bugfix][Rust Frontend] Restore prost test dependency - #56866
Merged
khluu merged 1 commit intoSep 14, 2026
Merged
Conversation
Co-authored-by: Sherlock <sherlock@raft.ai> Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
Member
Author
|
Exact validation is running in Buildkite #88872 at literal head |
Member
Author
|
Exact machine gate is green at literal head |
khluu
marked this pull request as ready for review
September 14, 2026 21:36
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 15, 2026
…6866) Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Co-authored-by: Sherlock <sherlock@raft.ai>
keneoneth
pushed a commit
to keneoneth/vllm
that referenced
this pull request
Sep 16, 2026
…6866) Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Co-authored-by: Sherlock <sherlock@raft.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore
prostas avllm-serverdev-dependency so its protobuf round-trip unit test compiles after thevllm-protocrate split.Root cause
PR #56338 added a
#[cfg(test)]import ofprost::Messageand calls toencode_to_vec()/decode(). Its exact CPU Rust Cargo and Cargo Style + Clippy jobs passed on the PR head in Buildkite #88199.Before #56338 merged, PR #56365 moved protobuf generation into the new
vllm-protocrate and removedprostfromvllm-server. The stale-but-green #56338 head then merged as1713a094, and main Buildkite #88858 failed deterministically in both CPU Rust Cargo jobs (and the equivalent MI250 jobs) with E0432/E0599.This adds the dependency under
[dev-dependencies], matching its test-only use, and updates the lockfile package dependency list.Validation
pre-commit run --files rust/src/server/Cargo.toml rust/Cargo.lock— passedgit diff --check— passedDuplicate check
Searched open vLLM PRs for
56338,prost Rust server dependency, andRust Frontend Cargo; no existing PR addresses this failure.AI assistance
AI assistance was used to diagnose the cross-merge failure, prepare the minimal dependency fix, and run the listed checks. This is a draft for human line review and exact CI validation before readiness.