Repository navigation
[CI] Pass the scale-out endpoint flag in EC E2E - #56819
Merged
DarkLight1337 merged 2 commits intoSep 15, 2026
Merged
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
Member
Author
|
Exact hardware validation is terminal green at
Lightweight checks and the exact two-L4 machine gate are now green. The remaining gate is human review. |
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com>
Contributor
|
Documentation preview: https://vllm--56819.org.readthedocs.build/en/56819/ |
tlrmchlsmth
marked this pull request as ready for review
September 14, 2026 16:57
tlrmchlsmth
requested review from
AndreasKaratzas,
DarkLight1337,
NickLucche,
aarnphm,
jperezdealgaba and
robertgshaw2-redhat
as code owners
September 14, 2026 16:57
tlrmchlsmth
approved these changes
Sep 14, 2026
Member
|
/ci run |
|
✅ Triggered Buildkite CI #88875 for commit |
Member
Author
|
Fresh main evidence strengthens the gate for this fix:
The isolated exact lane on this PR remains green in #88826. This is now repeated deterministic main breakage, not a one-off runner failure. |
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 15, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: OpenAI Codex <codex@openai.com> Co-authored-by: Tyler Michael Smith <tlrmchlsmth@gmail.com>
keneoneth
pushed a commit
to keneoneth/vllm
that referenced
this pull request
Sep 16, 2026
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com> Co-authored-by: OpenAI Codex <codex@openai.com> Co-authored-by: Tyler Michael Smith <tlrmchlsmth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VLLM_ENABLE_SCALE_OUT_ENDPOINTS=1setting in the scale-out EC E2E launcher--enable-scale-outto both ordinaryvllm serveprocesses that need/inference/v1/generateWhy
Merged PR #55176 replaced the environment gate with the
vllm serve --enable-scale-outflag, but the L4 Scale-out EC E2E script still uses the removed environment variable. Main build #88790 therefore started healthy encode and prefill servers without the generate route. Both the original job and its automatic retry failed the first encode request with HTTP 404.The exact Scale-out EC job did not run in PR #55176's green build #88768. This script is one of the job's direct source dependencies, so this change also forces exact PR-CI coverage of the repaired invocation.
Duplicate check
This is not a duplicate. I reviewed issue #55117 and its comments, searched open PRs by the issue number and by
enable-scale-out,Scale-out EC Connector E2E, and the 404 signature. The nearby open results concern Rust route support or unrelated scale-out features; none updates this E2E launcher.Validation
bash -n tests/entrypoints/scale_out/ec_integration/run_scale_out_ec_e2e_test.shshellcheck tests/entrypoints/scale_out/ec_integration/run_scale_out_ec_e2e_test.shpre-commit run --files tests/entrypoints/scale_out/ec_integration/run_scale_out_ec_e2e_test.shgit diff --check--enable-scale-outarguments and no removed environment-variable reference remain in the scriptAll pass locally. The exact two-L4 E2E job is required before merge. No model evaluation was run because this changes only the CI harness invocation, not serving output or model code.
AI assistance
OpenAI Codex was used to diagnose the main-CI failure, prepare this patch, and run the listed checks. A human submitter must review every changed line and understand the endpoint-registration behavior before merge.