Skip to content

[Fast Start] Use GPU uuid as socket folder identifier - #56669

Merged
ywang96 merged 3 commits into
vllm-project:mainfrom
Isotr0py:daemon-ready-check
Sep 14, 2026
Merged

[Fast Start] Use GPU uuid as socket folder identifier#56669
ywang96 merged 3 commits into
vllm-project:mainfrom
Isotr0py:daemon-ready-check

Conversation

@Isotr0py

@Isotr0py Isotr0py commented Sep 13, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

Purpose

  • Currently we uses GPU device local id as socket id, which is not robust enough, use GPU UUID as fast start daemon socket folder identifier
  • Also move some unnecessary lazy imports into top-level

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@Isotr0py
use GPU uuid as socket identifier
f3c8bc3 
Signed-off-by: Isotr0py <Isotr0py@outlook.com>
@Isotr0py
Isotr0py requested a review from 22quinn as a code owner September 13, 2026 06:17
claude[bot]
claude Bot reviewed Sep 13, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

liusy58
liusy58 approved these changes Sep 13, 2026
View reviewed changes

@liusy58 liusy58 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 13, 2026
@Isotr0py

Isotr0py commented Sep 13, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #88614 for commit f3c8bc3a90e7.

@ywang96

ywang96 commented Sep 13, 2026

Copy link
Copy Markdown
Member

/ci run

@ywang96
ywang96 enabled auto-merge (squash) September 13, 2026 22:08
@github-actions

github-actions Bot commented Sep 13, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #88690 for commit 2497a22c1c69.

@Isotr0py

Isotr0py commented Sep 14, 2026

Copy link
Copy Markdown
Member Author

/ci retry

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #88738 for commit e7ae9e87001d, running 2 failed step(s) from Buildkite CI #88690.

@ywang96
ywang96 merged commit dbf49da into vllm-project:main Sep 14, 2026
18 checks passed
@Isotr0py
Isotr0py deleted the daemon-ready-check branch September 14, 2026 06:36
@shaohuaxi shaohuaxi mentioned this pull request Sep 14, 2026
Merged
Shreya-gaur pushed a commit to Shreya-gaur/vllm_private that referenced this pull request Sep 14, 2026
@Isotr0py Shreya Gaur
[Fast Start] Use GPU uuid as socket folder identifier (vllm-project#5…
0fc61a1 
…6669)

Signed-off-by: Isotr0py <Isotr0py@outlook.com>
ItsRoy69 pushed a commit to ItsRoy69/vllm that referenced this pull request Sep 15, 2026
@Isotr0py @ItsRoy69
[Fast Start] Use GPU uuid as socket folder identifier (vllm-project#5…
28946ca 
…6669)

Signed-off-by: Isotr0py <Isotr0py@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@jeejeelee jeejeelee jeejeelee approved these changes
@ywang96 ywang96 ywang96 approved these changes
@22quinn 22quinn Awaiting requested review from 22quinn 22quinn is a code owner
+1 more reviewer
@liusy58 liusy58 liusy58 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Isotr0py @ywang96 @jeejeelee @liusy58