Skip to content

fix(multimodal): handle malformed EXIF gracefully in hasher - #56619

Closed
devtyagi3909 wants to merge 3 commits into
vllm-project:mainfrom
devtyagi3909:fix-hasher-exif
Closed

devtyagi3909 wants to merge 3 commits into
vllm-project:mainfrom
devtyagi3909:fix-hasher-exif

Conversation

@devtyagi3909

Copy link
Copy Markdown
Contributor

fixes #56527. wrap getexif() in a try-except block so malformed EXIF data falls through to normal hashing instead of crashing with a 500 error.

This adds from __future__ import annotations to prevent dataclasses from eagerly resolving the xgr.GrammarMatcher type hint, which would otherwise trigger the lazy loader and crash startup on platforms without xgrammar (e.g. s390x). Closes vllm-project#56559

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

PRs do not trigger a full CI run by default. Reviewers with write access and configured trusted contributors can comment /ci run for upstream CI or /amd-ci run for AMD CI only whenever CI signals are needed.

Once the PR is approved or has the ready label, the PR author can also use the corresponding /ci run, /ci retry, and /ci cancel commands, or their /amd-ci variants. New commits do not start upstream CI automatically.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

Agent Guidelines

IMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban.

🚀

Signed-off-by: DEV TYAGI <devtyagi3909@gmail.com>
@DarkLight1337

Copy link
Copy Markdown
Member

Sorry but there is already an open PR for this issue: #56576

@github-project-automation github-project-automation Bot moved this from Unsorted queue to In review in Structured Output (arpera) Sep 12, 2026
@devtyagi3909

Copy link
Copy Markdown
Contributor Author

ah missed that one, closing this out.

@arpera arpera moved this from In review to Done in Structured Output (arpera) Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) structured-output

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: malformed EXIF in an image fails the request with a 500 from MultiModalHasher.serialize_item

2 participants