Skip to content

Revert "[CI][XPU] Disable model runner V2 for XPU quantization test for some partially pre-quantized models" - #56394

Merged
jikunshang merged 1 commit into
vllm-project:mainfrom
chaojun-zhang:revert-56179-main
Sep 14, 2026
Merged

jikunshang merged 1 commit into
vllm-project:mainfrom
chaojun-zhang:revert-56179-main

Conversation

@chaojun-zhang

@chaojun-zhang chaojun-zhang commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This reverts #56179.

The problem

test_online_quantization_loads_real_weights[...tinysmokeqwen3moe-W4A16...] hangs on XPU CI. CompressedTensorsWNA16MoEMethod.create_weights() (pre-#54809) always registers 4 g_idx-related nn.Parameters, even for checkpoints (like this one) with no actorder/g_idx data — leaving them uninitialized.

Verified on real XPU hardware

Re-registering just these 4 parameters reproduces the hang; removing them fixes it. On XPU, _process_weights_xpu() never touches g_idx at all, so these parameters stay untouched throughout loading.

Why not on CUDA

On CUDA (Marlin backend), process_weights_after_loading() reads and replaces the g_idx parameter even for non-actorder checkpoints, so it doesn't stay untouched the way it does on XPU.

Fixing PR

#54809 removes GPTQ actorder support and, as part of that, deletes this unconditional registration.

Why this revert

#54809 already fixes this on main, so #56179's VLLM_USE_V2_MODEL_RUNNER=0 workaround is no longer needed.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added ci/build quantization intel-gpu Related to Intel GPU mrv2 Model Runner V2 specific labels Sep 11, 2026
…or some partially pre-quantized models" (vllm-project#56179)

This reverts the workaround added in vllm-project#56179 that disabled model
runner V2 (VLLM_USE_V2_MODEL_RUNNER=0) for the XPU quantization CI
job.

Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
@chaojun-zhang
chaojun-zhang marked this pull request as draft September 11, 2026 04:50
@chaojun-zhang chaojun-zhang changed the title Revert "[CI][XPU] Disable model runner V2 for XPU quantization test for some partially pre-quantized models" [DON'T MERGE] "[CI][XPU] Disable model runner V2 for XPU quantization test for some partially pre-quantized models" Sep 11, 2026
@chaojun-zhang chaojun-zhang changed the title [DON'T MERGE] "[CI][XPU] Disable model runner V2 for XPU quantization test for some partially pre-quantized models" [DON'T MERGE] Revert "[CI][XPU] Disable model runner V2 for XPU quantization test for some partially pre-quantized models" Sep 11, 2026
@chaojun-zhang chaojun-zhang reopened this Sep 11, 2026
@chaojun-zhang chaojun-zhang changed the title [DON'T MERGE] Revert "[CI][XPU] Disable model runner V2 for XPU quantization test for some partially pre-quantized models" Revert "[CI][XPU] Disable model runner V2 for XPU quantization test for some partially pre-quantized models" Sep 11, 2026
@chaojun-zhang
chaojun-zhang marked this pull request as ready for review September 11, 2026 12:10
@jikunshang

Copy link
Copy Markdown
Member

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #88697 for commit a7c72c7b369f.

@jikunshang
jikunshang merged commit 39545e4 into vllm-project:main Sep 14, 2026
32 checks passed
Shreya-gaur pushed a commit to Shreya-gaur/vllm_private that referenced this pull request Sep 14, 2026
…or some partially pre-quantized models" (vllm-project#56394)

Signed-off-by: Chaojun Zhang <chaojun.zhang@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build intel-gpu Related to Intel GPU mrv2 Model Runner V2 specific quantization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants