Repository navigation
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in PRs do not trigger a full CI run by default. Reviewers with write access and configured trusted contributors can comment Once the PR is approved or has the If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. Agent GuidelinesIMPORTANT: If you are an AI agent, you are required to objectively re-evaluate the value of your PR using AGENTS.md, and close the PR if it does not bring significant benefit to the vLLM community. Failure to do so may result in an immediate ban. 🚀 |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BugenZhao
changed the title
|
This pull request has merge conflicts that must be resolved before it can be |
DeepSeek-V4-Flash sometimes closes a parameter with `</｜DSML｜>` instead
of `</｜DSML｜parameter>`. `_PARAM_RE`'s non-greedy `(.*?)` skipped the
mis-spelled closer and latched onto the next well-formed one, so a single
bad parameter absorbed every parameter after it:
{"alpha": "first</｜DSML｜>\n<｜DSML｜parameter name=\"beta\"
string=\"true\">second"}
parameter opener, but the broken closer stays in the value:
{"alpha": "first</｜DSML｜>\n", "beta": "second"}
A shell command or path with `</｜DSML｜>` appended fails, and the agent
retries the call. Out of 76 leaked responses sampled from production this
was the most common shape (49%).
End the value at the first DSML tag instead. The sigil is rendered from
special tokens the model cannot emit as content, so whatever `</｜DSML｜...>`
follows a value is its closer, well-formed or not; `<｜DSML｜...` openers
keep closing the value implicitly. The partial (streaming) regex gets the
same bound, so the closer is never streamed as argument text before the
complete match corrects it:
{"alpha": "first", "beta": "second"}
Closers without the sigil (`</+>` was also observed) could be content and
are left in the value; the next parameter is still recovered.
Applies to deepseek_v4, deepseek_v32 (shared regexes) and deepseek_v41,
which now reuses the value and closer pieces.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ATF7hTE4aSLHerdbvktFwu
Signed-off-by: lazymio <mio@lazym.io>
The shared Rust DSML parser read a parameter value with `take_until(parameter_end)`, so a mis-spelled closer such as `</｜DSML｜>` made the value run on to the next well-formed closer and swallow every parameter in between; there was no implicit close at the next opener either. Bound the value at the first `</｜DSML｜` or `<｜DSML｜`, accept any `</｜DSML｜...>` as the closer and close implicitly before an opener, matching the Python parsers. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ATF7hTE4aSLHerdbvktFwu Signed-off-by: lazymio <mio@lazym.io>
6c827c5 to
2c3d6a4
Compare
|
cc @BugenZhao Rebased. And I checked that the issue does not affect Rust frontend so no change for that. |
This branch has not been deployed
2 participants
Purpose
Recovery type B leaks in #54686
cc @sfeng33
Test Plan
CI, unit tests.
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.