[CPU][Profiler] Group torch profiler tables by input shape when record_shapes is on - #56016
Merged
bigPYJ1151 merged 2 commits intoSep 14, 2026
Merged
Conversation
Chinmay-Kulkarni-AMD
marked this pull request as ready for review
September 9, 2026 06:28
dllehr-amd
self-requested a review
September 9, 2026 16:32
Contributor
|
Hi @Chinmay-Kulkarni-AMD, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, |
bigPYJ1151
approved these changes
Sep 11, 2026
bigPYJ1151
left a comment
Member
There was a problem hiding this comment.
Thanks @Chinmay-Kulkarni-AMD , LGTM :)
Please fix the pre-commit check.
…d_shapes is on Signed-off-by: Chinmay Kulkarni <Chinmay.Kulkarni@amd.com>
Chinmay-Kulkarni-AMD
force-pushed
the
profiler-shapes-info
branch
from
September 12, 2026 02:33
d2fb708 to
980165f
Compare
Contributor
Author
Hello @bigPYJ1151 , the pre-commit/linter issues are now fixed. |
Member
|
/ci run |
|
✅ Triggered Buildkite CI #88758 for commit |
Shreya-gaur
pushed a commit
to Shreya-gaur/vllm_private
that referenced
this pull request
Sep 14, 2026
…d_shapes is on (vllm-project#56016) Signed-off-by: Chinmay Kulkarni <Chinmay.Kulkarni@amd.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com>
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 15, 2026
…d_shapes is on (vllm-project#56016) Signed-off-by: Chinmay Kulkarni <Chinmay.Kulkarni@amd.com> Co-authored-by: Li, Jiang <jiang1.li@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Group PyTorch profiler
key_averagestables by input shape on the CPU platform when the user enables--profiler-config.torch_profiler_record_shapes=true.Without this, CPU dumps collapse every call of an op into one row, which hides prefill vs decode and GEMM size differences. GPU dumps are unchanged:
group_by_input_shapeis only set whencurrent_platform.is_cpu()andtorch_profiler_record_shapesare both true. Recording shapes remains user-controlled; it is not forced on the CPU platform.Test Plan
CPU throughput bench with torch profiler, shapes on:
Also confirm that
"torch_profiler_record_shapes": falsestill prints an ungrouped table, and that a GPU run does not passgroup_by_input_shape=True.Test Result
CPU dump (
torch_profiler_record_shapes=true) now has an Input Shapes column. The same op is split by GEMM / sequence shape (decode8vs prefill128):Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.