[Feature][Config] Support application-directed Mamba checkpoint token and input processing - #55873
Open
nicholaskh-ai wants to merge 1 commit into
Conversation
nicholaskh-ai
requested review from
DarkLight1337,
heheda12345,
hmellor,
ivanium and
njhill
as code owners
September 8, 2026 10:08
This was referenced Sep 8, 2026
Open
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Contributor
Author
|
Hi reviewers, this is Part 1 of the implementation stack for RFC #55697. It introduces the application-directed Mamba checkpoint token and InputProcessor parsing/multimodal alignment without altering model execution. Whenever you have a moment, we would appreciate your review and adding the |
nicholaskh-ai
force-pushed
the
feat/mamba-checkpoint-token-input-processor
branch
from
September 9, 2026 12:24
4cac14b to
56c4c64
Compare
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
nicholaskh-ai
force-pushed
the
feat/mamba-checkpoint-token-input-processor
branch
from
September 9, 2026 12:46
56c4c64 to
483434d
Compare
nicholaskh-ai
force-pushed
the
feat/mamba-checkpoint-token-input-processor
branch
from
September 9, 2026 16:09
483434d to
370f43e
Compare
…rker and input processing - Add --enable-mamba-checkpoint and --mamba-checkpoint-token CLI & engine options - Register <|mamba_checkpoint|> token into tokenizer dynamically in HF renderer - Parse and strip mamba checkpoint token in InputProcessor with offset adjustments - Add unit tests for HF renderer and InputProcessor token extraction Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com> Signed-off-by: nizhang1 <nizhang1@coupang.com>
nicholaskh-ai
force-pushed
the
feat/mamba-checkpoint-token-input-processor
branch
from
September 10, 2026 05:52
370f43e to
2377a44
Compare
KonnyakuMatcha
added a commit
to KonnyakuMatcha/vllm-HOT
that referenced
this pull request
Sep 14, 2026
Document the exact single-session HOT design, relationship to existing Mamba prefix-cache work (vllm-project#55697/vllm-project#55873/vllm-project#55875/vllm-project#55876, vllm-project#52959, vllm-project#45702), TTFT evaluation, correctness status, and async-scheduling limitations. Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: KonnyakuLC <1690982212@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Implements RFC #55697.
Part 1 of 3 for Application-Directed Mamba Prefix Checkpointing.
Hybrid GDN/Mamba architectures (e.g. Qwen3.5 35B-A3B) exhibit high state memory footprint (128KB-512KB per layer) compared to pure Attention. In catalog attribute extraction, multi-candidate verification, and agent workflows where 1 common product/document prefix is shared across multiple concurrent candidate queries, heuristics cannot safely determine application semantic boundaries (such as text prompt vs multimodal image boundaries).
This PR introduces explicit application-directed checkpointing at the input layer:
--enable-mamba-checkpointand--mamba-checkpoint-token(defaults to<|mamba_checkpoint|>) CLI & engine options.mamba_cache_mode = "align"when checkpointing is enabled.<|mamba_checkpoint|>as a special token in the HF renderer.InputProcessorwhile adjusting multimodal placeholder offsets.mamba_checkpoint_positionintoRequest.Follow-up PRs:
Duplicate-work Check
Test Plan
pytest tests/renderers/test_hf.py -k "test_ensure_mamba_checkpoint_token" -vpytest tests/v1/engine/test_input_processor_trace_replay.py -k "test_extract_mamba_checkpoint" -vpytest tests/v1/test_request.py -k "test_request_copies_session_id" -vAI assistance was used to prepare this change. The human submitter is responsible for reviewing the changed code and test results.
Generated with Devin
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Signed-off-by: nizhang1 nizhang1@coupang.com