Skip to content

[CI][ROCm] Add cache and release build regression coverage - #55672

Draft
AndreasKaratzas wants to merge 1 commit into
akaratza_deps_bugfixfrom
akaratza_deps_tests
Draft

AndreasKaratzas wants to merge 1 commit into
akaratza_deps_bugfixfrom
akaratza_deps_tests

Conversation

@AndreasKaratzas

@AndreasKaratzas AndreasKaratzas commented Sep 7, 2026

Copy link
Copy Markdown
Member

Add regression coverage for the ROCm image dependency and cache fixes in #55093. This PR is stacked on akaratza_deps_bugfix; review and merge #55093 first.

  • Extend tests/tools/test_docker_build_metadata_args.py with dependency-lock, cache-key/manifest, forced-refresh, digest-handoff, TorchCodec, and literal build-argument coverage.
  • Add tests/tools/test_rocm_release_build.py to exercise release cache hits/misses, rebuilds, failures, and cleanup with fake Docker/AWS/cache commands.
  • Update the CPU and AMD Buildkite metadata jobs and file triggers to run both suites.

AI assistance was used to split the existing changes, validate the two branches, and draft this description.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Stack the existing regression coverage on the cache-safe image dependency
fixes. Cover build/cache contracts and isolated release orchestration, and
wire both suites into the CPU and AMD Buildkite metadata jobs.

Extracted unchanged from #55093; the completed stack has the same tree as
d094e57.

Co-authored-by: OpenAI Codex <noreply@openai.com>
Signed-off-by: Andreas Karatzas <akaratza@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build rocm Related to AMD ROCm

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant