Skip to content

[CI][ROCm] Temporarily skip unsupported HY-V4 initialization - #55653

Merged
Isotr0py merged 1 commit into
mainfrom
akaratza_skip_hyv4_init
Sep 7, 2026
Merged

Isotr0py merged 1 commit into
mainfrom
akaratza_skip_hyv4_init

Conversation

@AndreasKaratzas

@AndreasKaratzas AndreasKaratzas commented Sep 7, 2026

Copy link
Copy Markdown
Member

HY-V4's CUDA-only implementation in #54160 raises NotImplementedError: hy_v4 does not yet support ROCm during the two HY initialization cases in AMD build 12635 and build 12653. This temporarily skips those unsupported cases while model enablement in #54405 and its backend dependency #54404 are completed. Remove this guard alongside ROCm model enablement; this CI-only change is separate from those support implementations.

  • Skip only HYV4ForCausalLM and HYV4MTPModel initialization on ROCm.

Prepared with AI assistance (OpenAI Codex).

Assisted-by: OpenAI Codex
Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@mergify mergify Bot added the rocm Related to AMD ROCm label Sep 7, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Sep 7, 2026
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 359bcde7-a599-4fd1-8b99-1341bfc75197

📥 Commits

Reviewing files that changed from the base of the PR and between d9105ea and 1dd6ab1.

📒 Files selected for processing (1)
  • tests/models/test_initialization.py

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Updated initialization test coverage to skip certain HyV4 model cases on ROCm pending an upstream change.

Walkthrough

The initialization test now skips HYV4ForCausalLM and HYV4MTPModel on ROCm. Other platforms and model architectures retain the existing initialization behavior.

Changes

ROCm initialization testing

Layer / File(s) Summary
Add ROCm-specific HYV4 skip
tests/models/test_initialization.py
test_can_initialize_large_subset calls pytest.skip for the two HYV4 architectures when current_platform.is_rocm() is true.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1dd6a

On ROCm, the two unsupported HYV4 initialization checks now report as skipped rather than failing, while other initialization coverage remains unchanged. No merge-blocking risk remains.

Suggested reviewers: hmellor, isotr0py, zjy0516

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the temporary ROCm skip for unsupported HY-V4 initialization tests.
Description check ✅ Passed The description directly explains the ROCm failure, the limited test skip, and the condition for removing the guard.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AndreasKaratzas

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #87491 for commit 1dd6ab18c36f.

AndreasKaratzas added a commit that referenced this pull request Sep 7, 2026
Merge the validated backend dependency while preserving the existing HY-V4
and MTP platform enablement. Remove the temporary ROCm initialization guard
introduced by #55653 now that both exact model initialization cases pass.

Validation: 4 HY initialization/registry cases and 55 backend/kernel tests
passed without skips on the identical full source tree.

Assisted-by: OpenAI Codex
Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
@Isotr0py
Isotr0py merged commit 195bc9c into main Sep 7, 2026
38 of 40 checks passed
@Isotr0py
Isotr0py deleted the akaratza_skip_hyv4_init branch September 7, 2026 07:17
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Sep 7, 2026
ItsRoy69 pushed a commit to ItsRoy69/vllm that referenced this pull request Sep 10, 2026
…oject#55653)

Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants