[CI][ROCm] Temporarily skip unsupported HY-V4 initialization - #55653
Conversation
Assisted-by: OpenAI Codex Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe initialization test now skips ChangesROCm initialization testing
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to On ROCm, the two unsupported HYV4 initialization checks now report as skipped rather than failing, while other initialization coverage remains unchanged. No merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ci run |
|
✅ Triggered Buildkite CI #87491 for commit |
Merge the validated backend dependency while preserving the existing HY-V4 and MTP platform enablement. Remove the temporary ROCm initialization guard introduced by #55653 now that both exact model initialization cases pass. Validation: 4 HY initialization/registry cases and 55 backend/kernel tests passed without skips on the identical full source tree. Assisted-by: OpenAI Codex Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
…oject#55653) Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
HY-V4's CUDA-only implementation in #54160 raises
NotImplementedError: hy_v4 does not yet support ROCmduring the two HY initialization cases in AMD build 12635 and build 12653. This temporarily skips those unsupported cases while model enablement in #54405 and its backend dependency #54404 are completed. Remove this guard alongside ROCm model enablement; this CI-only change is separate from those support implementations.HYV4ForCausalLMandHYV4MTPModelinitialization on ROCm.Prepared with AI assistance (OpenAI Codex).