[Bugfix][Audio] Restore soundfile-first automatic decoding - #55642
Conversation
Assisted-by: OpenAI Codex Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Documentation preview: https://vllm--55642.org.readthedocs.build/en/55642/ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe audio ChangesAudio backend order
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Automatic audio decoding now preserves soundfile-supported waveform lengths while retaining fallbacks for unsupported formats. The implementation, regression coverage, and documentation are aligned, with no remaining merge-readiness risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ci run |
|
✅ Triggered Buildkite CI #87481 for commit |
…ect#55642) Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com> Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
Speech jobs passed in AMD build 12635 before PR #51826 made TorchCodec the preferred automatic audio decoder. A local GPU
git bisectidentified its merge commit,6a039f465e37, as the cause of thetest_long_audio_requestfailures in build 12653 on MI300 and MI355. With TorchCodec 0.10 and FFmpeg 4.4.2, the Mary Vorbis fixture gains 192 padding samples at 16 kHz, changing repeated-audio boundaries and reducing recognized phrase repetitions from ten to seven.Prepared with AI assistance. The recorded upstream duplicate audit found no matching open fix for this decoder-priority regression.