[CI] Align extraction test with canonical auxiliary layer order - #55457
Merged
khluu merged 1 commit intoSep 6, 2026
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: khluu <khluu000@gmail.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #87388 for commit |
AndreasKaratzas
approved these changes
Sep 6, 2026
Member
|
@khluu Can we merge this? It also resolves a failure in AMD CI. |
yewentao256
approved these changes
Sep 6, 2026
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
khluu
marked this pull request as ready for review
September 6, 2026 18:22
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 10, 2026
…-project#55457) Signed-off-by: khluu <khluu000@gmail.com> Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The H200 MIG hidden-state extraction lane fails its predictable-model layer assertion and then cannot start the following Qwen3.5 test because the first test's engine retains GPU memory (main build 87376).
#50514 intentionally canonicalizes auxiliary layer IDs by sorting and deduplicating them. The integration test supplies
[5, 2, 10]but still expects the output in that input order, while the model now returns[2, 5, 10]. Keep the unsorted input and check all three extraction scenarios against canonical order, consistent with the existing auxiliary-layer unit test. Run the predictable-model test in its own process using the existing helper so engine memory is released before the next test.Duplicate checks: open-PR searches for
extraction auxiliary hidden sortedandextract_hidden_statesfound no equivalent ordering/process-isolation fix; existing extraction PRs address separate cache layout, model coverage, and documentation changes.Validation:
git diff --checkpassed.VLLM_TARGET_DEVICE=cpu .venv/bin/python -m pytest -q tests/v1/worker/test_eagle3_aux_hidden_states_pp.py: 2 passed, confirming the established sorted/deduplicated contract.h200-ci-1, existing main image784cac7c424db2f2fdc879b672abad7e231f5698, with this test and current-mainvllm/model_executor/models/interfaces.pymounted:/tmp/.venv/bin/python -m pytest -v tests/v1/kv_connector/extract_hidden_states_integration/test_extraction.py -k 'predictable or qwen35': 2 passed, 1 deselected in 132.69s. The venv was created withuv venv --system-site-packages /tmp/.venv.AI assistance was used for investigation, implementation, and validation. Draft for human review and exact-lane CI; human line-by-line review has not been represented as completed.
CI follow-up: Buildkite 87388 was triggered for this PR head. The exact regression job(s) are enabled: (H200 MIG 18GB) Extract Hidden States Integration. At 2026-09-05T10:52:05+00:00, they were waiting for image/dependency jobs; no successful end-to-end result is claimed.