Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions tests/renderers/test_warmup.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ def _make_renderer_mock(mm_limits: dict[str, int]) -> MagicMock:
renderer._mm_warmup_done = False
renderer.clear_mm_cache = MagicMock()
renderer.model_config.max_model_len = 128
renderer.config.scheduler_config.max_num_batched_tokens = 8192
renderer.model_config.get_multimodal_config.return_value.limit_per_prompt = {}

return renderer
Expand Down Expand Up @@ -115,6 +116,19 @@ class TestMmWarmupRunsNormally:
# MM warmup must run when mm_processor is set and limits > 0; the chat
# template warmup must run alongside it.

@pytest.mark.parametrize(
("max_model_len", "expected_seq_len"), [(491520, 8192), (128, 128)]
)
def test_warmup_sequence_length_is_bounded(self, max_model_len, expected_seq_len):
renderer = _make_renderer_mock({"image": 1, "video": 1})
renderer.model_config.max_model_len = max_model_len

with patch("vllm.multimodal.processing.TimingContext", autospec=True):
BaseRenderer.warmup(renderer, ChatParams())

get_inputs = renderer.mm_processor.dummy_inputs.get_dummy_processor_inputs
assert get_inputs.call_args.kwargs["seq_len"] == expected_seq_len

def test_processor_apply_called(self):
renderer = _make_renderer_mock({"image": 1})

Expand Down
5 changes: 4 additions & 1 deletion vllm/renderers/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,10 @@ def _warmup_mm_processor(

start_time = time.perf_counter()
processor_inputs = processor.dummy_inputs.get_dummy_processor_inputs(
seq_len=model_config.max_model_len,
seq_len=min(
Comment thread
lucamotz marked this conversation as resolved.
Resolved
model_config.max_model_len,
self.config.scheduler_config.max_num_batched_tokens,
),
mm_counts=dict.fromkeys(mm_limits, 1),
mm_options=mm_config.limit_per_prompt,
)
Expand Down