Skip to content

[Bugfix][Kernel] Fix top-k selection when the radix threshold bin overflows the smem stash #55314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dovis01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix][Kernel] Fix top-k selection when the radix threshold bin overflows the smem stash #55314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions csrc/libtorch_stable/cooperative_topk.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,6 +598,11 @@ constexpr size_t kSmemSize2 = kSmemSize4;
constexpr size_t kSmemSize8 =
sizeof(SmemFused<kFusedStagesCS8>) + sizeof(int32_t) * 2048 + 128;

static_assert(sizeof(hist4096::Histogram4096Smem<kMaxTopK, 12>) <= kSmemSize4,
"cooperative smem must cover histogram_4096_topk");
static_assert(sizeof(hist4096::Histogram4096Smem<kMaxTopK, 12>) <= kSmemSize8,
"cooperative smem must cover histogram_4096_topk");

} // namespace cooperative

} // namespace vllm
Expand Down
Loading
Loading