[CI] Remove deleted nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 and its arch aliases - #55026
Conversation
…6 from test registry The HF repo nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 has been removed from Hugging Face (404), causing multimodal processor tests that parameterize on it to fail, e.g.: FAILED models/multimodal/processing/test_common.py::test_processing_correctness[1.0-32-0.5-nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16_0] pydantic_core._pydantic_core.ValidationError: 1 validation error for ModelConfig Remove the three test-registry entries pointing at the deleted repo (NemotronH_Nano_Omni_Reasoning_V3, NemotronH_Super_Omni_Reasoning_V3, NemotronH_Omni_Reasoning_V3) and the now-unused PretrainedConfig import. The arch aliases in vllm/model_executor/models/registry.py are kept: they map to NemotronH_Nano_VL_V2, which is still tested via nvidia/NVIDIA-Nemotron-Nano-12B-v2-VL-BF16. Co-authored-by: Kimi Code <noreply@moonshot.cn> Signed-off-by: khluu <khluu000@gmail.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe test and production multimodal model registries remove three NemotronH entries. The test registry also removes the unused ChangesModel registry cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes tests for a deleted model repository without altering production behavior. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Title checkExplanation The title clearly describes the main change: removing references to the deleted Nemotron model from the test registry. It is specific and related to the pull request, although the changes remove three related registry entries. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The only checkpoint ever associated with these architectures (nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16) was removed from Hugging Face, so no loadable model uses these arch names. Remove the aliases from the model registry and the now-dead MTP text_config promotion in SpeculativeConfig. This also keeps tests/models/test_registry.py::test_hf_registry_coverage passing after the corresponding test-registry entries were removed. Co-authored-by: Kimi Code <noreply@moonshot.cn> Signed-off-by: khluu <khluu000@gmail.com>
…6 and its arch aliases (vllm-project#55026) Signed-off-by: khluu <khluu000@gmail.com> Co-authored-by: Kimi Code <noreply@moonshot.cn>
…6 and its arch aliases (#55026) Signed-off-by: khluu <khluu000@gmail.com> Co-authored-by: Kimi Code <noreply@moonshot.cn>
|
am i crazy or does this exist and is not 404'd? https://huggingface.co/nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 |
It was 404'ing for a while at least ... |
Purpose
The HF repo
nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16has been removed from Hugging Face (404). Tests that parameterize on it now fail, e.g. in https://buildkite.com/vllm/ci/builds/86943#01a063ed-36c0-435f-84ec-efd837f9eec7:That deleted repo was the only checkpoint ever associated with the three
NemotronH_*_Omni_Reasoning_V3architectures (two of them were already markedis_available_online=Falsewith a TODO to update the repo id once public). This PR removes them entirely:tests/models/registry.py: drop theNemotronH_Nano_Omni_Reasoning_V3,NemotronH_Super_Omni_Reasoning_V3, andNemotronH_Omni_Reasoning_V3entries (plus the now-unusedPretrainedConfigimport).vllm/model_executor/models/registry.py: drop the three arch aliases (they mapped toNemotronH_Nano_VL_V2, which remains registered and is still tested vianvidia/NVIDIA-Nemotron-Nano-12B-v2-VL-BF16).vllm/config/speculative.py: drop the now-dead MTPtext_configpromotion for the two omni arch names.Removing the aliases (not just the test entries) is required to keep
tests/models/test_registry.py::test_hf_registry_coveragepassing — it asserts every registered arch has a test-registry entry.Duplicate-work check
Searched open PRs and issues for
Nemotron-3-Nano-Omni/NemotronH_Nano_Omni— no existing PR addresses this removal.Test plan
ast.parse); no references to the deleted repo or the three arch names remain in the repo.test_registry.py).AI assistance
This change was made with AI assistance (Kimi Code CLI).
Summary by CodeRabbit
Chores
Behavior Changes