Skip to content

[CI] Remove deleted nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 and its arch aliases - #55026

Merged
khluu merged 2 commits into
vllm-project:mainfrom
khluu:fix/remove-deleted-nemotron-omni-model
Sep 2, 2026
Merged

khluu merged 2 commits into
vllm-project:mainfrom
khluu:fix/remove-deleted-nemotron-omni-model

Conversation

@khluu

@khluu khluu commented Sep 2, 2026

Copy link
Copy Markdown
Member

Purpose

The HF repo nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 has been removed from Hugging Face (404). Tests that parameterize on it now fail, e.g. in https://buildkite.com/vllm/ci/builds/86943#01a063ed-36c0-435f-84ec-efd837f9eec7:

FAILED models/multimodal/processing/test_common.py::test_processing_correctness[1.0-32-0.5-nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16_0]
pydantic_core._pydantic_core.ValidationError: 1 validation error for ModelConfig

That deleted repo was the only checkpoint ever associated with the three NemotronH_*_Omni_Reasoning_V3 architectures (two of them were already marked is_available_online=False with a TODO to update the repo id once public). This PR removes them entirely:

  • tests/models/registry.py: drop the NemotronH_Nano_Omni_Reasoning_V3, NemotronH_Super_Omni_Reasoning_V3, and NemotronH_Omni_Reasoning_V3 entries (plus the now-unused PretrainedConfig import).
  • vllm/model_executor/models/registry.py: drop the three arch aliases (they mapped to NemotronH_Nano_VL_V2, which remains registered and is still tested via nvidia/NVIDIA-Nemotron-Nano-12B-v2-VL-BF16).
  • vllm/config/speculative.py: drop the now-dead MTP text_config promotion for the two omni arch names.

Removing the aliases (not just the test entries) is required to keep tests/models/test_registry.py::test_hf_registry_coverage passing — it asserts every registered arch has a test-registry entry.

Duplicate-work check

Searched open PRs and issues for Nemotron-3-Nano-Omni / NemotronH_Nano_Omni — no existing PR addresses this removal.

Test plan

  • All touched files parse cleanly (ast.parse); no references to the deleted repo or the three arch names remain in the repo.
  • Could not run pytest locally (env missing deps); the affected CI jobs are the multimodal processor shard (currently failing on the 404) and Basic Models (Other) (test_registry.py).

AI assistance

This change was made with AI assistance (Kimi Code CLI).

Summary by CodeRabbit

  • Chores

    • Removed three NemotronH Omni Reasoning V3 variants from multimodal model examples and architecture listings.
    • Simplified related test configuration.
  • Behavior Changes

    • NemotronH Omni VLM checkpoints are no longer automatically rewritten to MTP configurations during speculative decoding.
    • Removed automatic vision configuration overrides for the affected Nano variant.

…6 from test registry

The HF repo nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 has been
removed from Hugging Face (404), causing multimodal processor tests that
parameterize on it to fail, e.g.:

FAILED models/multimodal/processing/test_common.py::test_processing_correctness[1.0-32-0.5-nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16_0]
pydantic_core._pydantic_core.ValidationError: 1 validation error for ModelConfig

Remove the three test-registry entries pointing at the deleted repo
(NemotronH_Nano_Omni_Reasoning_V3, NemotronH_Super_Omni_Reasoning_V3,
NemotronH_Omni_Reasoning_V3) and the now-unused PretrainedConfig import.

The arch aliases in vllm/model_executor/models/registry.py are kept: they
map to NemotronH_Nano_VL_V2, which is still tested via
nvidia/NVIDIA-Nemotron-Nano-12B-v2-VL-BF16.

Co-authored-by: Kimi Code <noreply@moonshot.cn>
Signed-off-by: khluu <khluu000@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 124eb25d-1845-4ccf-91d9-b9a50b68b2bb

📥 Commits

Reviewing files that changed from the base of the PR and between e75251d and 20254c6.

📒 Files selected for processing (2)
  • vllm/config/speculative.py
  • vllm/model_executor/models/registry.py

📝 Walkthrough

Walkthrough

The test and production multimodal model registries remove three NemotronH entries. The test registry also removes the unused PretrainedConfig import.

Changes

Model registry cleanup

Layer / File(s) Summary
Remove NemotronH registry entries
tests/models/registry.py, vllm/model_executor/models/registry.py
Both registries remove the three NemotronH multimodal entries. The test registry also removes the unused PretrainedConfig import.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e7525

This change removes tests for a deleted model repository without altering production behavior. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: removing references to the deleted Nemotron model from the test registry. It is specific and related to the pull request, although the changes remove three…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title clearly describes the main change: removing references to the deleted Nemotron model from the test registry. It is specific and related to the pull request, although the changes remove three related registry entries.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@njhill njhill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khluu

@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Sep 2, 2026
The only checkpoint ever associated with these architectures
(nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16) was removed from
Hugging Face, so no loadable model uses these arch names. Remove the
aliases from the model registry and the now-dead MTP text_config
promotion in SpeculativeConfig.

This also keeps tests/models/test_registry.py::test_hf_registry_coverage
passing after the corresponding test-registry entries were removed.

Co-authored-by: Kimi Code <noreply@moonshot.cn>
Signed-off-by: khluu <khluu000@gmail.com>
@khluu khluu changed the title [CI] Remove deleted nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 from test registry [CI] Remove deleted nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16 and its arch aliases Sep 2, 2026
@khluu
khluu merged commit 6c6376a into vllm-project:main Sep 2, 2026
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Sep 2, 2026
mylibrar pushed a commit to tanyuqian/vllm that referenced this pull request Sep 3, 2026
…6 and its arch aliases (vllm-project#55026)

Signed-off-by: khluu <khluu000@gmail.com>
Co-authored-by: Kimi Code <noreply@moonshot.cn>
khluu added a commit that referenced this pull request Sep 4, 2026
…6 and its arch aliases (#55026)

Signed-off-by: khluu <khluu000@gmail.com>
Co-authored-by: Kimi Code <noreply@moonshot.cn>
@davidscarth

Copy link
Copy Markdown

am i crazy or does this exist and is not 404'd?

https://huggingface.co/nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16

@njhill

njhill commented Sep 4, 2026

Copy link
Copy Markdown
Member

am i crazy or does this exist and is not 404'd?

https://huggingface.co/nvidia/Nemotron-3-Nano-Omni-30B-A3B-Reasoning-BF16

It was 404'ing for a while at least ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants