[ROCm][Installation] Add mooncake package to image using public wheels - #55002
Conversation
Signed-off-by: Giuseppe Grossi <ggrossi@amd.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe ROCm image and CI configuration remove Mooncake build and cache integration. The ROCm requirements add ChangesROCm Mooncake integration
Merge Risk: 🔵 Low · up to ROCm images will now resolve Mooncake from a public wheel using only a minimum version, so later rebuilds may change image contents and make source-only rollback non-reproducible. The PR is mergeable with explicit owner awareness or follow-up to pin the reviewed version and artifact hash. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ci run |
|
✅ Triggered Buildkite CI #86933 for commit |
|
/amd-ci run |
|
✅ Triggered Buildkite AMD CI #12572 for commit |
Purpose
Updating the recent PR#52650 by removing those changes and simply installing mooncake via the public wheels that are now published.
Same testing was done as original PR, and the results are the same.
Addressed issue #51193
Summary by CodeRabbit