Skip to content

[ROCm][Installation] Add mooncake package to image using public wheels - #55002

Merged
AndreasKaratzas merged 2 commits into
vllm-project:mainfrom
giuseppegrossi:feat/mooncake-install-wheels
Sep 3, 2026
Merged

[ROCm][Installation] Add mooncake package to image using public wheels#55002
AndreasKaratzas merged 2 commits into
vllm-project:mainfrom
giuseppegrossi:feat/mooncake-install-wheels

Conversation

@giuseppegrossi

@giuseppegrossi giuseppegrossi commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Purpose

Updating the recent PR#52650 by removing those changes and simply installing mooncake via the public wheels that are now published.

Same testing was done as original PR, and the results are the same.

Addressed issue #51193

Summary by CodeRabbit

  • Changes
    • ROCm build requirements now include the Mooncake transfer engine, version 0.3.13 or later, supporting KV-cache transfer and offloading.
    • Mooncake is no longer built, packaged, installed, or recorded in ROCm Docker images.
    • Mooncake-specific ROCm CI cache targets and cache configuration have been removed.
    • Existing ROCm support for NIXL, ROCShmem, and DeepEP remains unchanged.

Signed-off-by: Giuseppe Grossi <ggrossi@amd.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 089a5b5f-b7b5-42f5-be45-935496ecd2ac

📥 Commits

Reviewing files that changed from the base of the PR and between 1356635 and f2f6d84.

📒 Files selected for processing (4)
  • .buildkite/scripts/ci-bake-rocm.sh
  • docker/Dockerfile.rocm
  • docker/ci-rocm.hcl
  • requirements/rocm.txt

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The ROCm image and CI configuration remove Mooncake build and cache integration. The ROCm requirements add mooncake-transfer-engine-rocm >= 0.3.13.

Changes

ROCm Mooncake integration

Layer / File(s) Summary
ROCm image dependency and metadata
requirements/rocm.txt, docker/Dockerfile.rocm
The ROCm requirements add the Mooncake transfer engine. The final image removes Mooncake arguments and version metadata.
ROCm CI cache cleanup
.buildkite/scripts/ci-bake-rocm.sh, docker/ci-rocm.hcl
ROCm CI removes Mooncake stages, pin extraction, cache keys, cache references, cache targets, and automatic seeding. NIXL, ROCShmem, and DeepEP cache handling remains.Estimated code review effort: 2 (Simple)

Merge Risk: 🔵 Low · up to 4a3da

ROCm images will now resolve Mooncake from a public wheel using only a minimum version, so later rebuilds may change image contents and make source-only rollback non-reproducible. The PR is mergeable with explicit owner awareness or follow-up to pin the reviewed version and artifact hash.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly states that the pull request adds the Mooncake package to the ROCm image through public wheels. This matches the stated objective and the dependency update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added ci/build rocm Related to AMD ROCm labels Sep 2, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Sep 2, 2026
@AndreasKaratzas

Copy link
Copy Markdown
Member

/ci run

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite CI #86933 for commit 4a3dad804857.

@AndreasKaratzas

Copy link
Copy Markdown
Member

/amd-ci run

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

✅ Triggered Buildkite AMD CI #12572 for commit 4a3dad804857.

@AndreasKaratzas
AndreasKaratzas merged commit e47356c into vllm-project:main Sep 3, 2026
22 of 23 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants