[Bugfix][Rust Frontend][Renderer] Align DeepSeek V4 historical developer message handling - #54854
Conversation
Signed-off-by: reidliu41 <reid201711@gmail.com>
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
/ci run |
|
✅ @reidliu41, CI is now available for this PR.
|
|
✅ Triggered Buildkite CI #86936 for commit |
…per message handling (vllm-project#54854) Signed-off-by: reidliu41 <reid201711@gmail.com>
Purpose
The Rust DeepSeek V4 renderer kept developer messages that appeared before the
last user-like turn when
thinking=trueand effectivedrop_thinking=true.The Python tokenizer and the official DeepSeek encoding remove those historical
developer messages while preserving assistant answers and dropping historical
reasoning.
Align the Rust DeepSeek V4 renderer with the Python tokenizer and the official
DeepSeek encoding when dropping historical thinking messages.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.