Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions vllm/config/parallel.py
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,6 @@ def _validate_parallel_config(self) -> Self:
tp = self.tensor_parallel_size
pcp = self.prefill_context_parallel_size
dcp = self.decode_context_parallel_size
if pcp > 1 and self.data_parallel_size > 1:
raise ValueError("PCP does not support data parallelism yet.")
if pcp == 1:
# DCP reuses the TP ranks when PCP is disabled.
if tp % dcp != 0:
Expand Down
6 changes: 6 additions & 0 deletions vllm/platforms/cuda.py
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,12 @@ def check_and_update_config(cls, vllm_config: VllmConfig) -> None:
parallel_config = vllm_config.parallel_config
model_config = vllm_config.model_config

if (
parallel_config.prefill_context_parallel_size > 1
and parallel_config.data_parallel_size > 1
):
raise ValueError("PCP does not support data parallelism on CUDA yet.")

if parallel_config.worker_cls == "auto":
parallel_config.worker_cls = "vllm.v1.worker.gpu_worker.Worker"

Expand Down
6 changes: 6 additions & 0 deletions vllm/platforms/rocm.py
Original file line number Diff line number Diff line change
Expand Up @@ -900,6 +900,12 @@ def check_and_update_config(cls, vllm_config: "VllmConfig") -> None:
compilation_config = vllm_config.compilation_config
parallel_config = vllm_config.parallel_config

if (
parallel_config.prefill_context_parallel_size > 1
and parallel_config.data_parallel_size > 1
):
raise ValueError("PCP does not support data parallelism on ROCm yet.")

if (
compilation_config.cudagraph_mode.has_full_cudagraphs()
and parallel_config.prefill_context_parallel_size > 1
Expand Down
Loading