[Config] Raise ValueError instead of assert for DBO all2all backend validation - #54512
Edge-Explorer wants to merge 10 commits into
Conversation
…lidation Signed-off-by: Karan Shelar <karanshelar8775@gmail.com>
dfce661 to
a13466c
Compare
|
Hi @youkaichao Just bumping this whenever you have a moment to take a look. I've replaced the raw assert in |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 SummarySummary by CodeRabbit
Walkthrough
ChangesMicrobatching validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Unsupported all2all backends now fail with a descriptive configuration error, including when Python assertions are optimized out, and the default unsupported DBO configuration is covered by a test. The change is ready to merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Resolves issue #54493.
When starting the server with --enable-dbo (Double-Buffered Overlap / Microbatching), the config verification for supported all2all backends would fail with a raw Python AssertionError instead of a clean, user-friendly exception.
I updated the validation logic in vllm/config/vllm.py to raise a descriptive ValueError instead of a raw assert. This allows the server to exit gracefully and gives the user clear instructions on which --all2all-backend flags are compatible with microbatching.
Test Plan
I added a configuration unit test to verify that setting
enable_dbo=Truewith default/unsupported backends raises the correctValueError.You can run the unit test with:
Test Result
The unit test passes successfully:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.