Skip to content

[Bugfix][Core] Fail cleanly for unsupported DBO backends - #54511

Draft
cyq1017 wants to merge 2 commits into
vllm-project:mainfrom
cyq1017:codex/vllm-54493-dbo-validation
Draft

cyq1017 wants to merge 2 commits into
vllm-project:mainfrom
cyq1017:codex/vllm-54493-dbo-validation

Conversation

@cyq1017

@cyq1017 cyq1017 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Purpose

Fixes #54493.

Replace the DBO all2all backend assert with a ValueError so unsupported configurations fail consistently even when Python assertions are disabled. The existing supported-backend list and remediation guidance are preserved.

This change was prepared with assistance from OpenAI Codex and reviewed by the contributor.

Test Plan

python -m pytest --noconftest -o addopts= -q \
  tests/test_config.py::test_all2all_backend_has_portable_default \
  tests/test_config.py::test_ubatching_rejects_unsupported_all2all_backend
ruff check vllm/config/vllm.py tests/test_config.py
ruff format --check vllm/config/vllm.py tests/test_config.py

Test Result

2 passed, 15 warnings in 4.26s
All checks passed!
2 files already formatted

The warnings are from the source checkout version lookup and PyTorch JIT deprecations.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. (Not applicable.)

Assisted-by: OpenAI Codex
Signed-off-by: cyq <15000851237@163.com>
Assisted-by: OpenAI Codex
Signed-off-by: cyq <15000851237@163.com>
@cyq1017 cyq1017 changed the title Fail cleanly for unsupported DBO backends [Bugfix][Core] Fail cleanly for unsupported DBO backends Aug 31, 2026
@mergify mergify Bot added the bug Something isn't working label Aug 31, 2026
@mergify

mergify Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @cyq1017.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working needs-rebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: --enable-dbo reaches an assertion-backed all2all backend validation failure

1 participant