[Bugfix] Avoid global config lookup in sparse indexer forward - #54400
Merged
khluu merged 1 commit intoAug 30, 2026
Merged
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Member
Author
|
/ci run |
|
✅ Triggered Buildkite CI #86202 for commit |
ZJY0516
marked this pull request as draft
August 30, 2026 08:20
ZJY0516
marked this pull request as ready for review
August 30, 2026 08:22
khluu
approved these changes
Aug 30, 2026
am-cohere
pushed a commit
to am-cohere/vllm
that referenced
this pull request
Sep 1, 2026
…roject#54400) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Co-authored-by: OpenAI Codex <codex@openai.com>
Leoyzen
pushed a commit
to Leoyzen/vllm
that referenced
this pull request
Sep 1, 2026
…roject#54400) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Co-authored-by: OpenAI Codex <codex@openai.com>
Leoyzen
added a commit
to Leoyzen/vllm
that referenced
this pull request
Sep 1, 2026
mylibrar
pushed a commit
to tanyuqian/vllm
that referenced
this pull request
Sep 3, 2026
…roject#54400) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Co-authored-by: OpenAI Codex <codex@openai.com>
D-G-Dimitrov
pushed a commit
to D-G-Dimitrov/vllm
that referenced
this pull request
Sep 5, 2026
…roject#54400) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com> Co-authored-by: OpenAI Codex <codex@openai.com> (cherry picked from commit 8c51b92)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the DeepSeek-V4-Flash startup regression seen in Buildkite CI #86195. During memory profiling,
SparseAttnIndexerreads the current vLLM config from a global context after the model-construction context has exited, causing EngineCore initialization to fail.Fix
Keep a reference to the
ParallelConfigcaptured during model construction and read the late-adjustedcp_kv_cache_interleave_sizefrom that object during forward.This preserves the post-construction PD+DCP interleave adjustment introduced by #50611 while avoiding a forward-time
get_current_vllm_config()call.AI assistance
AI assistance was used to diagnose the CI failure, prepare the code change, run validation, and draft this PR. The PR remains a draft so the human submitter can review every changed line and validate the change end-to-end before marking it ready.