Repository navigation
[Bugfix] Validate scale-out transfer params - #54324
Merged
yewentao256 merged 3 commits intoAug 30, 2026
Merged
yewentao256 merged 3 commits into
yewentao256 merged 3 commits into
Conversation
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
yewentao256
approved these changes
Aug 30, 2026
yewentao256
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for the work!
|
✅ @taneem-ibrahim, CI is now available for this PR.
|
Contributor
Author
|
/ci run |
|
✅ Triggered Buildkite CI #86196 for commit |
am-cohere
pushed a commit
to am-cohere/vllm
that referenced
this pull request
Sep 1, 2026
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
mylibrar
pushed a commit
to tanyuqian/vllm
that referenced
this pull request
Sep 3, 2026
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
D-G-Dimitrov
pushed a commit
to D-G-Dimitrov/vllm
that referenced
this pull request
Sep 5, 2026
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com> (cherry picked from commit fe6db3e)
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #54116.
The
/inference/v1/generateendpoint validatedsampling_paramsfor MessagePack compatibility before dispatch, but omittedkv_transfer_paramsandec_transfer_params. Oversized integers in either field therefore failed later during engine serialization and surfaced as HTTP 500InternalServerError.This change validates all three values together before engine dispatch. Serialization errors now use the existing HTTP 400
BadRequestErrorresponse path, while valid generation remains unchanged.Reproducer
Start the server:
PATH="$PWD/.venv/bin:$PATH" CUDA_VISIBLE_DEVICES=0 \ vllm serve Qwen/Qwen3-0.6B \ --dtype bfloat16 \ --max-model-len 1024 \ --enforce-eager \ --no-enable-prefix-cachingSend requests to
/inference/v1/generateusing:{ "model": "Qwen/Qwen3-0.6B", "token_ids": [1, 2, 3], "sampling_params": { "max_tokens": 1, "temperature": 0.0, "seed": 0 }, "stream": false, "kv_transfer_params": { "oversized_integer": 158541820065335999920888242752337176824 } }Repeat with
ec_transfer_paramsin place ofkv_transfer_params, then omit both fields for the ordinary-generation control request.Output on main
Output on branch
Test Plan
PATH="$PWD/.venv/bin:$PATH" CUDA_VISIBLE_DEVICES=0 \ HF_HUB_CACHE=/tmp/vllm-hf-cache \ .venv/bin/python -m pytest \ tests/entrypoints/openai/test_openai_schema.py::test_openapi_stateless \ -q --tb=shortPATH="$PWD/.venv/bin:$PATH" CUDA_VISIBLE_DEVICES=0 \ HF_HUB_CACHE=/tmp/vllm-hf-cache \ .venv/bin/python -m pytest \ tests/entrypoints/scale_out/token_in_token_out/ \ -q --tb=shortAI assistance disclosure
OpenAI Codex (GPT-5) assisted with drafting the code.