[Bugfix][Parser] Seed-OSS turn-boundary tokens + boundary-fallback tests - #54264
Merged
Merged
Conversation
…r disabled thinking Follow-up to vllm-project#54089: the turn-boundary fallback returns `initial_state != REASONING`, but all existing boundary tests ran with thinking enabled. Add a focused test for the CONTENT arm (thinking disabled + marker-free prompt tail -> reasoning ended) and a control for the REASONING arm Signed-off-by: Mikhail Podvitskii <podvitskiymichael@gmail.com>
…ng-end detection Signed-off-by: Mikhail Podvitskii <podvitskiymichael@gmail.com>
Xarbirus
requested review from
aarnphm,
bbrowning,
chaunceyjiang and
sfeng33
as code owners
August 28, 2026 20:04
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
mergify
Bot
added
qwen
|
✅ @Xarbirus, CI is now available for this PR.
|
Collaborator
|
/ci run |
sfeng33
enabled auto-merge (squash)
September 9, 2026 22:16
|
✅ Triggered Buildkite CI #88002 for commit |
ItsRoy69
pushed a commit
to ItsRoy69/vllm
that referenced
this pull request
Sep 10, 2026
…sts (vllm-project#54264) Signed-off-by: Mikhail Podvitskii <podvitskiymichael@gmail.com> Co-authored-by: Flora Feng <4florafeng@gmail.com> Signed-off-by: Jyotirmoy Roy <jyotirmoyroy649@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #54089, covering two items:
SeedOSS turn boundaries.
SeedOssParserinherits the ChatML turn boundaries (<|im_start|>/<|im_end|>) fromQwen3Parser, but they are absent from the Seed vocab, so the current-turn scoping from [Bugfix][Parser] Scope reasoning-end detection to the current turn via turn-boundary tokens #54089 was silently disabled there. OverrideTURN_BOUNDARIESwith<seed:bos>/<seed:eos>(verified against the realByteDance-Seed/Seed-OSS-36B-Instructtokenizer:<seed:bos>(id 0) /<seed:eos>(id 2) are single vocab tokens).Pin the boundary-fallback CONTENT arm. The fallback returns
initial_state != REASONING, but all boundary tests in [Bugfix][Parser] Scope reasoning-end detection to the current turn via turn-boundary tokens #54089 ran with thinking enabled. Add focused tests for thinking disabled plus an enabled-state control.Test Plan
Test Result
Tested on H100
tests/parser/engine/test_seed_oss.py: 11 passed (incl. 3 new turn-boundary tests)tests/parser/engine/test_qwen3_reasoning.py: 59 passed (incl. 2 new fallback tests)tests/parsersuite: 4091 passed, 0 failuresEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.