Repository navigation
[Bugfix] Format kernel-import errors eagerly so warning_once does not retain them #54098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yewentao256
merged 7 commits into
vllm-project:main
from
zwang86:fix-warning-once-exception-leak
Sep 15, 2026
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
356cb47
[Bugfix] Format kernel-import errors eagerly so warning_once does not…
zwang86 b9ba25c
Merge branch 'main' into fix-warning-once-exception-leak
zwang86 d7f6b55
Remove explanatory comment per review
zwang86 5d69171
Remove regression test per review
zwang86 8e656af
Merge branch 'main' into fix-warning-once-exception-leak
zwang86 393bf4f
Merge branch 'main' into fix-warning-once-exception-leak
mergify[bot] f82ca61
Merge branch 'main' into fix-warning-once-exception-leak
zwang86 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -365,7 +365,10 @@ def import_kernels(cls) -> None: | |||||||||||
| try: | ||||||||||||
| import vllm._C # noqa: F401 | ||||||||||||
| except ImportError as e: | ||||||||||||
| logger.warning_once("Failed to import from vllm._C: %r", e) | ||||||||||||
| # Format eagerly: warning_once caches its arguments forever, and a | ||||||||||||
| # live exception would pin its traceback (and every local on the | ||||||||||||
| # raising path, including the LLM under construction). | ||||||||||||
| logger.warning_once("Failed to import from vllm._C: %s", repr(e)) | ||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Comment not needed There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed the comment |
||||||||||||
| with contextlib.suppress(ImportError): | ||||||||||||
| import vllm._moe_C_stable_libtorch # noqa: F401 | ||||||||||||
|
|
||||||||||||
|
|
||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need a specific test for this small update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed the test