Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Signed-off-by: mayuyuace <qiming1.zhang@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a compilation regression introduced in #51674 for sm8x architectures (Ampere/Ada: A100, A10, L20, RTX 4090, etc.).
Root Cause
In #51674, fused_gdn_decode_post_conv_mtp was added to ops.h inside the existing #ifdef VLLM_ENABLE_FUSED_KDA_DECODE block (after fused_kda_decode) instead of a new #ifdef VLLM_ENABLE_FUSED_GDN_DECODE block. Since VLLM_ENABLE_FUSED_KDA_DECODE only applies to sm9.0a+, sm8x builds get VLLM_ENABLE_FUSED_GDN_DECODE=1 without the declaration being visible, causing:
error: 'fused_gdn_decode_post_conv_mtp' was not declared in this scopeFix
Move the declaration to its own
#ifdef VLLM_ENABLE_FUSED_GDN_DECODEblock.CI was unaffected because it runs on Hopper/Blackwell where both macros are defined simultaneously.
How to reproduce:
docker build -f docker/Dockerfile --target vllm-openai
--build-arg torch_cuda_arch_list="8.9" .