Repository navigation
[Refactor] Remove utils dead code #53941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a1bf5c8
remove dead code util
yewentao256 c8e17f7
Merge branch 'main' into wentao-remove-dead-code-util
yewentao256 056dafe
Merge branch 'main' into wentao-remove-dead-code-util
yewentao256 6eb1e70
Merge branch 'main' into wentao-remove-dead-code-util
yewentao256 ee047f4
Merge branch 'main' into wentao-remove-dead-code-util
yewentao256 dfdad73
fix ci
yewentao256 d593061
Merge branch 'main' into wentao-remove-dead-code-util
yewentao256 b102789
fix ci
yewentao256 fa96f5f
Merge branch 'main' into wentao-remove-dead-code-util
yewentao256 6bf157f
add kb back
yewentao256 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,15 +14,11 @@ | |
| from vllm.logger import init_logger | ||
| from vllm.platforms import current_platform | ||
|
|
||
| from .mem_constants import GiB_bytes, KiB_bytes, MiB_bytes | ||
| from .mem_constants import GiB_bytes, MiB_bytes | ||
|
|
||
| logger = init_logger(__name__) | ||
|
|
||
|
|
||
| def format_kib(b: int) -> str: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's keep this just for completeness sake |
||
| return f"{round(b / KiB_bytes, 2)}" | ||
|
|
||
|
|
||
| def format_mib(b: int) -> str: | ||
| return f"{round(b / MiB_bytes, 2)}" | ||
|
|
||
|
|
@@ -43,11 +39,6 @@ def get_max_shared_memory_bytes(gpu: int = 0) -> int: | |
| return int(max_shared_mem) | ||
|
|
||
|
|
||
| def get_cpu_memory() -> int: | ||
| """Returns the total CPU memory of the node in bytes.""" | ||
| return psutil.virtual_memory().total | ||
|
|
||
|
|
||
| _UMA_PRESSURE_THRESHOLD = 0.8 | ||
| _UMA_MIN_RELEASE_BYTES = 512 * MiB_bytes | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 7975
🏁 Script executed:
Repository: vllm-project/vllm
Length of output: 15844
Restore the
KiB_bytescompatibility export.tests/models/multimodal/generation/test_memory_leak.pyimportsKiB_bytesfromvllm.utils.mem_utils, but that module no longer binds the symbol. The test can fail during import. Preserve the export or update the test to import it fromvllm.utils.mem_constants.📍 Affects 2 files
vllm/utils/mem_utils.py#L17-L17(this comment)vllm/utils/mem_utils.py#L41-L41vllm/v1/attention/backends/utils.py#L6-L6vllm/v1/attention/backends/utils.py#L978-L978🤖 Prompt for AI Agents