Skip to content

[Misc] Remove VLLM_BUILD_WITH_NEURON env variable#5389

Merged
WoosukKwon merged 1 commit intomainfrom
neuron-env
Jun 11, 2024
Merged

[Misc] Remove VLLM_BUILD_WITH_NEURON env variable#5389
WoosukKwon merged 1 commit intomainfrom
neuron-env

Conversation

@WoosukKwon
Copy link
Copy Markdown
Collaborator

Use VLLM_TARGET_DEVICE instead of VLLM_BUILD_WITH_NEURON.

Copy link
Copy Markdown
Contributor

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WoosukKwon WoosukKwon enabled auto-merge (squash) June 10, 2024 18:23
@WoosukKwon WoosukKwon disabled auto-merge June 11, 2024 07:37
@WoosukKwon WoosukKwon merged commit 8bab495 into main Jun 11, 2024
@WoosukKwon WoosukKwon deleted the neuron-env branch June 11, 2024 07:37
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 12, 2024
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants