Repository navigation
[Quantization] Support Humming W4A8 Block in CT - #53880
Open
robertgshaw2-redhat wants to merge 1 commit into
Open
robertgshaw2-redhat wants to merge 1 commit into
robertgshaw2-redhat wants to merge 1 commit into
Conversation
robertgshaw2-redhat
requested review from
AndreasKaratzas,
mgoin,
pavanimajety,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
August 26, 2026 11:42
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
robertgshaw2-redhat
added
the
ready
Collaborator
Author
|
/ci run |
|
✅ Triggered Buildkite CI #85647 for commit |
Contributor
|
@HDCharles can you take a look |
HDCharles
reviewed
Sep 8, 2026
| self.experts_cls: type[mk.FusedMoEExperts] | ||
| if moe.moe_backend == "b12x": | ||
| if moe.moe_backend in ORACLE_MOE_BACKENDS: | ||
| self.mxfp4_backend, experts_cls = select_mxfp4_moe_backend(moe) |
Contributor
There was a problem hiding this comment.
seems like hte activation info needs to be routed through here too, right?
Contributor
|
i made #55963 you can incorporate those fixes or we can land that, the main issue i see with this PR is that it doesn't update the mxfp4 oracle to actually accept humming + float8 block. |
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.