Repository navigation
[CI] Include chat template fallbacks in package_data - #53762
Merged
DarkLight1337 merged 4 commits intoSep 2, 2026
Merged
Conversation
Ship transformers_utils/chat_templates/*.jinja in sdists and wheels so built-in multimodal fallback templates referenced by registry.py are available after pip install, including builds from source archives without a git checkout. Signed-off-by: Tarun Kumar <takumar@redhat.com>
tarukumar
force-pushed
the
fix/chat-templates-package-data
branch
from
August 25, 2026 16:32
5a962ee to
900b125
Compare
DarkLight1337
approved these changes
Sep 2, 2026
DarkLight1337
enabled auto-merge (squash)
September 2, 2026 03:56
Member
|
/ci run |
|
✅ Triggered Buildkite CI #86792 for commit |
mylibrar
pushed a commit
to tanyuqian/vllm
that referenced
this pull request
Sep 3, 2026
Signed-off-by: Tarun Kumar <takumar@redhat.com>
michael-gpu
pushed a commit
to practical-inference/vllm-ampere-extended
that referenced
this pull request
Oct 20, 2026
Signed-off-by: Tarun Kumar <takumar@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
vllm/transformers_utils/chat_templates/registry.pyresolves built-in multimodal chat template fallbacks from files such astemplate_chatml.jinjain the same directory. After installing vLLM from a wheel built from a source archive (without a git checkout), only the Python modules are present:The
*.jinjafiles are missing, which breaks models that rely on these fallbacks when no Hugging Face chat template is available.Root cause
__init__.pyandregistry.pyare installed automatically as Python package modules.*.jinjafiles are package data and are not listed inpackage_dataorMANIFEST.in.egg_info.SOURCES.txtwithout the.jinjafiles, so they are omitted from sdists and wheels.Fix
Declare the templates explicitly in
setup.py:"transformers_utils/chat_templates/*.jinja",Verification
Before this change, the wheel contains only
__init__.pyandregistry.py. After this change, alltemplate_*.jinjafiles are included.LOG:
If people do not copy the template it fails like this if you are creating a wheel and installing it