Skip to content

[Hardware][AMD][Perf][Bugfix] Update ROCr and clr in base image - #53712

Merged
AndreasKaratzas merged 1 commit into
vllm-project:mainfrom
ROCm:mawong/rocr_clr_update
Aug 26, 2026
Merged

AndreasKaratzas merged 1 commit into
vllm-project:mainfrom
ROCm:mawong/rocr_clr_update

Conversation

@mawong-amd

@mawong-amd mawong-amd commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Purpose

This PR updates ROCR and CLR in the ROCm 7.2.3 vLLM base image to backport in some bugfixes for graph replay (which was segfaulting under replay of complex graphs under some workloads) and for kernel dispatch latency under some stream dependencies.

In particular, the latter fix improves decode performance measurably on a few workloads (particularly --async-scheduling and ModelRunner V2):

  1. DeepSeek V4, ISL=1024, OSL=512, TP=8, gfx950. This translates to about 20% TPOT improvement in the best case at concurrency 1, shrinking to 9% at concurrency 64.
  2. Kimi K3, ISL=1024, OSL=512, TP=8, gfx950. This translates to about 13% TPOT improvement in the best case at concurrency 1, shrinking to 4% at concurrency 64.

Test Plan

GSM8K was measured on a number of models and configs on both gfx950 and gfx942 and in line with numbers before the runtime change. Also, full AMD CI will be triggered on this PR.

Test Result

There should not be any regressions in AMD CI caused by this PR.


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added ci/build rocm Related to AMD ROCm bug Something isn't working labels Aug 25, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Aug 25, 2026
ARG MORI_REPO="https://github.com/ROCm/mori.git"
ARG ROCPROFILER_SDK_REPO="https://github.com/ROCm/rocm-systems.git"
ARG ROCPROFILER_SDK_COMMIT="2b22ab0195cc1461cd9abf3b969e9dd7c10af350"
ARG ROCM_RUNTIME_REPO="https://github.com/mawong-amd/rocm-systems.git"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a rocm repo not the personal ones will be better?

Or update the base image of rocm/dev-ubuntu-22.04:7.2.3-complete to rocm/dev-ubuntu-22.04:7.14.0-full

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not so simple to do a full migration to ROCm 7.14: that also brings in newer hipBLASLt, RCCL, etc, all of which needs to be verified for performance and numerical accuracy. See #49925 which has been a work in progress for a while.

The ROCm 7.2.4 runtimes are essentially the ROCm 7.2.3 runtimes with some bolt-on fixes/improvements and are drop-in safe. On top of ROCm 7.2.4, the runtime here also carries an incipient fix with large performance implications for some stream dependencies. With that in mind, it makes sense to bring it in as soon as possible, after appropriate testing on vLLM workloads.

@mawong-amd mawong-amd changed the title [Hardware][AMD][Bugfix] Update ROCr and clr in base image [Hardware][AMD][Perf][Bugfix] Update ROCr and clr in base image Aug 25, 2026
…ng edge signals

Dockerfile.rocm_base builds the HSA runtime and clr from
mawong-amd/rocm-systems, pinned at c7e40e16bca10311af72aee09cfa0cd1726f70a7,
and installs the resulting shared libraries over the ones the ROCm 7.2.3 base
image ships.

The stage is defined before base and installs into base, not into final.
Every FROM base stage compiles and links against the runtime it will run on.
Installing only into final would leave torch, triton, flash-attention, aiter
and mori built against the image's headers but running against these
libraries.

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
@mawong-amd
mawong-amd force-pushed the mawong/rocr_clr_update branch from 435f340 to 12be5eb Compare August 25, 2026 15:54

@AndreasKaratzas AndreasKaratzas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually an emergency patch. We have agreed to a proper follow up PR. So we will merge this for now and soon we'll redirect to the official rocm repo.

@AndreasKaratzas
AndreasKaratzas merged commit 796822d into vllm-project:main Aug 26, 2026
101 checks passed
@AndreasKaratzas
AndreasKaratzas deleted the mawong/rocr_clr_update branch August 26, 2026 07:38
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Aug 26, 2026
khushali9 pushed a commit to khushali9/vllm that referenced this pull request Aug 29, 2026
…-project#53712)

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: khushali9 <khushali.desai9@gmail.com>
am-cohere pushed a commit to am-cohere/vllm that referenced this pull request Sep 1, 2026
mikeshawcode pushed a commit to mikeshawcode/vllm that referenced this pull request Sep 1, 2026
…-project#53712)

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: mikeshawcode <michaelwshaw2@gmail.com>
mikeshawcode pushed a commit to mikeshawcode/vllm that referenced this pull request Sep 1, 2026
…-project#53712)

Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
Signed-off-by: mikeshawcode <michaelwshaw2@gmail.com>
mylibrar pushed a commit to tanyuqian/vllm that referenced this pull request Sep 3, 2026
@stefanskiasan

Copy link
Copy Markdown

Data point from a different workload, in case it helps calibrate expectations: we overlaid exactly the two libraries this PR builds (libamdhip64.so.7.2.53211-c7e40e1, libhsa-runtime64.so.1.18.0, taken from vllm/vllm-openai-rocm:nightly 2026-09-02) onto a 7.2.3-based image and measured full GLM-5.3 (glm_moe_dsa, MXFP4 experts, fp8 KV, sparse MLA via the ROCm AITER path, MTP k=3, FULL cudagraphs) at TP4 on MI355X, same instance, same night, stock runtime vs. backport:

decode bs=1 throughput 64 users mean TPOT
stock 7.2.3 runtime (instance b) 121 / 122 tok/s 617 / 634 tok/s 45.6 / 44.6 ms
backport (instance b) 118 / 115 tok/s 619 / 630 tok/s 45.1 / 44.3 ms
stock 7.2.3 runtime (instance a) 124 / 120 tok/s 617 / 604 tok/s 45.5 / 46.6 ms
backport (instance a) 120 / 122 tok/s 570* / 615 tok/s 46.2 / 45.4 ms

(*coincided with a 235 MB/s model download on the host.) So no measurable change for this TP4 / sparse-MLA / MTP configuration — the DeepSeek-V4 TP8 gains presumably come from the stream-dependency pattern that our path does not have. Correctness unchanged (needle tests to 900k tokens, perplexity). Not a complaint, just a "your mileage may vary" for TP4 setups.

sheralskumar pushed a commit to sheralskumar/vllm that referenced this pull request Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci/build rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants