[Misc] Various simplifications and typing fixes#5368
Merged
DarkLight1337 merged 3 commits intovllm-project:mainfrom Jun 11, 2024
Merged
[Misc] Various simplifications and typing fixes#5368DarkLight1337 merged 3 commits intovllm-project:mainfrom
DarkLight1337 merged 3 commits intovllm-project:mainfrom
Conversation
Noticed while working on other features.
njhill
commented
Jun 9, 2024
| dim=0, | ||
| dtype=query_start_loc.dtype, | ||
| out=query_start_loc[1:]) | ||
|
|
Member
Author
There was a problem hiding this comment.
These tensors aren't used in the flashinfer case
DarkLight1337
approved these changes
Jun 10, 2024
DarkLight1337
requested changes
Jun 10, 2024
Member
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Sorry I approved too early. Looks like you broke the speculative decoding code.
Member
Author
|
Thanks @DarkLight1337! It was a small mistake, have now pushed a fix. |
DarkLight1337
approved these changes
Jun 11, 2024
tjohnson31415
added a commit
to tjohnson31415/vllm
that referenced
this pull request
Jun 11, 2024
* upstream/main: (126 commits) [Bugfix][Frontend] Cleanup "fix chat logprobs" (vllm-project#5026) [Bugfix] OpenAI entrypoint limits logprobs while ignoring server defined --max-logprobs (vllm-project#5312) [Misc] Various simplifications and typing fixes (vllm-project#5368) [ci] Fix Buildkite agent path (vllm-project#5392) [Doc] Add documentation for FP8 W8A8 (vllm-project#5388) Bump version to v0.5.0 (vllm-project#5384) [Docs] Alphabetically sort sponsors (vllm-project#5386) [Docs] Add Docs on Limitations of VLM Support (vllm-project#5383) [ci] Mount buildkite agent on Docker container to upload benchmark results (vllm-project#5330) [ci] Use small_cpu_queue for doc build (vllm-project#5331) [Bugfix] Fix LLaVA-NeXT (vllm-project#5380) [Feature][Frontend]: Continued `stream_options` implementation also in CompletionRequest (vllm-project#5319) [Model] Initial support for LLaVA-NeXT (vllm-project#4199) [Misc] Improve error message when LoRA parsing fails (vllm-project#5194) [misc][typo] fix typo (vllm-project#5372) [Frontend][Misc] Enforce Pixel Values as Input Type for VLMs in API Server (vllm-project#5374) [Misc] Update to comply with the new `compressed-tensors` config (vllm-project#5350) [Bugfix] Fix KeyError: 1 When Using LoRA adapters (vllm-project#5164) [Kernel][Misc] Use TORCH_LIBRARY instead of PYBIND11_MODULE for custom ops (vllm-project#5047) [mis][ci/test] fix flaky test in test_sharded_state_loader.py (vllm-project#5361) ...
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 12, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while working on other features, thought it would be cleaner to split into a separate PR.