Skip to content

[Bugfix] BailingMoeV3 KDA: skip absent metadata during CUDA graph profiling - #53593

Merged
njhill merged 1 commit into
vllm-project:mainfrom
njhill:fix-bailing-kda-profile-metadata
Aug 25, 2026
Merged

njhill merged 1 commit into
vllm-project:mainfrom
njhill:fix-bailing-kda-profile-metadata

Conversation

@njhill

@njhill njhill commented Aug 24, 2026

Copy link
Copy Markdown
Member

PR #53306 omits Mamba-family groups from dummy-run attention metadata. BailingMoeV3KimiDeltaAttention still indexed its entry directly, raising KeyError during V2 engine-init warmup dummy runs. Use the same missing-entry guard as the other GDN/KDA paths (see also #53581).

Co-authored-by: Kimi Code CLI

…filing

PR vllm-project#53306 omits Mamba-family groups from dummy-run attention metadata.
BailingMoeV3KimiDeltaAttention still indexed its entry directly, raising
KeyError during V2 engine-init warmup dummy runs. Use the same
missing-entry guard as the other GDN/KDA paths (see also vllm-project#53581).

Co-authored-by: Kimi Code CLI
Signed-off-by: Nick Hill <nickhill123@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@mergify mergify Bot added the nvidia label Aug 24, 2026
@mergify mergify Bot added the bug Something isn't working label Aug 24, 2026
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 24, 2026
@njhill

njhill commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

/ci run

@github-actions

Copy link
Copy Markdown

✅ Triggered Buildkite CI #85351 for commit 0921779122e0.

@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Aug 25, 2026
@njhill
njhill enabled auto-merge (squash) August 25, 2026 00:22
@njhill
njhill merged commit 09fddeb into vllm-project:main Aug 25, 2026
99 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Aug 25, 2026
@njhill
njhill deleted the fix-bailing-kda-profile-metadata branch August 25, 2026 05:57
am-cohere pushed a commit to am-cohere/vllm that referenced this pull request Sep 1, 2026
…filing (vllm-project#53593)

Signed-off-by: Nick Hill <nickhill123@gmail.com>
mikeshawcode pushed a commit to mikeshawcode/vllm that referenced this pull request Sep 1, 2026
…filing (vllm-project#53593)

Signed-off-by: Nick Hill <nickhill123@gmail.com>
Signed-off-by: mikeshawcode <michaelwshaw2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants