[Bugfix][MiniMax] Reset Lamport workspace after wake-up - #53511
Open
Ronald1995 wants to merge 3 commits into
Open
Ronald1995 wants to merge 3 commits into
Ronald1995 wants to merge 3 commits into
Conversation
Signed-off-by: Ronald1995 <ronaldautomobile@163.com>
Signed-off-by: Ronald1995 <ronaldautomobile@163.com>
Signed-off-by: Ronald1995 <ronaldautomobile@163.com>
Ronald1995
requested review from
22quinn,
AndreasKaratzas,
WoosukKwon,
mgoin,
njhill,
pavanimajety,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
zyongye
as code owners
August 24, 2026 03:29
This was referenced Aug 24, 2026
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Part of #53343. Split from #53344.
MiniMax fused RMS-QK uses a Lamport communication workspace containing flags, layout values, sentinels, and device pointers. Registered buffers can restore old bytes, but protocol state must instead be reset to a valid initial state after wake-up while preserving storage addresses captured by CUDA Graphs.
Changes
LamportWorkspaceowner while retaining the tensor-returning compatibility API;post_weights_wake_uphook;Dependency
Depends on #53510 for the wake-hook dispatcher. #53510 itself depends on #53509.
This is a stacked PR. Merge order:
GitHub will reduce the diff as the prerequisite PRs merge.
Test Plan
Changed files pass Ruff,
git diff --check, and Python compilation. Distributed CUDA kernel validation is delegated to CI.