[CI/Build] Pin Cython below 3.3 for arm64 tilelang sdist - #53358
Conversation
436092f to
b53b2f5
Compare
|
Exact arm64 validation is terminal green at current head
This is proposed-fix validation only. Final resolution still requires merge plus a post-merge cold/main |
|
New evidence after PR #53374 merged changes the minimum fix:
This PR's broader |
|
Superseding my earlier Cython-only minimum-fix note with exact GH200 evidence:
Together with literal-head arm64 #85162 passing, this validates the current paired |
The aarch64 builder cannot install tilelang's manylinux_2_34 wheel, so uv builds tilelang from sdist. Cython 3.3 rejects tilelang's hardcoded Python Limited API 3.8 setting before tests can run. Constrain uv's isolated aarch64 build environments to Cython below 3.3. x86_64 continues to install tilelang's wheel and is unaffected. Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com>
b53b2f5 to
66ad0ef
Compare
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com> (cherry picked from commit e25c586)
* Add schema 2 GrugMoE inference * [CI/Build] Pin Cython below 3.3 for arm64 tilelang sdist (vllm-project#53358) Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com> (cherry picked from commit e25c586) * Deterministic MoE combine (reduce_scatterv) under VLLM_BATCH_INVARIANT Signed-off-by: shijuzhao <758710341@qq.com> Signed-off-by: shijuzhao <shijuzhao@tencent.com> * Clarify Hero GrugMoE support * Remove redundant GrugMoE state --------- Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Signed-off-by: shijuzhao <shijuzhao@tencent.com> Co-authored-by: yoblin <268258002+yoblin@users.noreply.github.com> Co-authored-by: Kevin H. Luu <khluu000@gmail.com> Co-authored-by: OpenAI Codex <codex@openai.com> Co-authored-by: shijuzhao <shijuzhao@tencent.com>
…t#53358) Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com>
…t#53358) Signed-off-by: Kevin Luu <51931015+khluu@users.noreply.github.com> Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: mikeshawcode <michaelwshaw2@gmail.com>
Purpose
Fix the deterministic arm64 image-build failure caused by Cython 3.3 while building
tilelang==0.1.12from source. No test runs: the image fails during dependency installation.Exact reproductions on the restored immutable builder image:
Root cause
The aarch64 build base is manylinux 2_28 / glibc 2.28, so it cannot install tilelang's
manylinux_2_34aarch64 wheel and uv builds tilelang from sdist. Fresh isolated builds now resolve Cython 3.3, which rejects tilelang's hardcodedPy_LIMITED_API=0x03080000because Cython 3.3 requires Python Limited API 3.9 or newer. The previous successful build used the same immutable builder before Cython 3.3 was released, so it resolved an older compatible Cython.Change
On aarch64 only, set uv's isolated-build constraint to
cython<3.3before installing CUDA requirements. x86_64 continues to install tilelang's wheel and is unaffected. CMake is no longer constrained; the restored builder remains on its existing CMake 4.4.2.Duplicate-work check
Searched open PRs for
cython arm64 tilelang,cython 3.3, andtilelang build. This PR was already the only open match, so it was narrowed in place instead of opening a duplicate.Test status
uvx --from pre-commit pre-commit run --files docker/Dockerfile: passed, including Dockerfile dependency-graph andversions.jsonvalidation.66ad0efdceb4: passed exit 0 in 39m34s, including the tilelang sdist build and complete vLLM image build/push under CMake 4.4.2.e25c586b9030; post-merge main arm64 #85235 passed exit 0 in 39m21s, including the complete image build and registry push.7f17348fd67c(exact merge commit plus only the selector scaffoldkey: gh200-teston a non-main validation branch) completed the full wheel build and reached Dockerbuild 17/17with neither build-tool failure. It stopped only at the separately baseline-known wheel-size gate: 561.96 MB > 500 MB (baseline #84342: 552.17 MB > 500 MB). No retry.Post-merge arm64 and GH200 both cleared the Cython/Limited-API and fatal CUDA imported-location signatures. This incident is resolved on main; the GH200 wheel-size gate remains separate baseline debt.
AI-assistance disclosure
This change was prepared with AI assistance and reviewed before submission.